diff options
author | Johan Hovold <jhovold@gmail.com> | 2014-05-26 13:23:29 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-27 18:04:08 -0400 |
commit | 7d5dddda088ed054f1519d03f997346c03bfc778 (patch) | |
tree | 8d58dce7b796d794fc7e7ef3cc7c7bfe838a5257 /drivers/usb/serial | |
parent | 9fdf7063ec9e239f309e79b65fc62fd8bfa9da5c (diff) |
USB: usb_wwan: remove some superfluous comments
Remove some more outdated or superfluous comments.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial')
-rw-r--r-- | drivers/usb/serial/usb_wwan.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index 5042faa5d588..c951f75891c9 100644 --- a/drivers/usb/serial/usb_wwan.c +++ b/drivers/usb/serial/usb_wwan.c | |||
@@ -178,7 +178,6 @@ int usb_wwan_ioctl(struct tty_struct *tty, | |||
178 | } | 178 | } |
179 | EXPORT_SYMBOL(usb_wwan_ioctl); | 179 | EXPORT_SYMBOL(usb_wwan_ioctl); |
180 | 180 | ||
181 | /* Write */ | ||
182 | int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port, | 181 | int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port, |
183 | const unsigned char *buf, int count) | 182 | const unsigned char *buf, int count) |
184 | { | 183 | { |
@@ -429,7 +428,6 @@ void usb_wwan_close(struct usb_serial_port *port) | |||
429 | 428 | ||
430 | portdata = usb_get_serial_port_data(port); | 429 | portdata = usb_get_serial_port_data(port); |
431 | 430 | ||
432 | /* Stop reading/writing urbs */ | ||
433 | spin_lock_irq(&intfdata->susp_lock); | 431 | spin_lock_irq(&intfdata->susp_lock); |
434 | portdata->opened = 0; | 432 | portdata->opened = 0; |
435 | if (--intfdata->open_ports == 0) | 433 | if (--intfdata->open_ports == 0) |
@@ -454,7 +452,6 @@ void usb_wwan_close(struct usb_serial_port *port) | |||
454 | } | 452 | } |
455 | EXPORT_SYMBOL(usb_wwan_close); | 453 | EXPORT_SYMBOL(usb_wwan_close); |
456 | 454 | ||
457 | /* Helper functions used by usb_wwan_setup_urbs */ | ||
458 | static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port, | 455 | static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port, |
459 | int endpoint, | 456 | int endpoint, |
460 | int dir, void *ctx, char *buf, int len, | 457 | int dir, void *ctx, char *buf, int len, |
@@ -467,7 +464,6 @@ static struct urb *usb_wwan_setup_urb(struct usb_serial_port *port, | |||
467 | if (!urb) | 464 | if (!urb) |
468 | return NULL; | 465 | return NULL; |
469 | 466 | ||
470 | /* Fill URB using supplied data. */ | ||
471 | usb_fill_bulk_urb(urb, serial->dev, | 467 | usb_fill_bulk_urb(urb, serial->dev, |
472 | usb_sndbulkpipe(serial->dev, endpoint) | dir, | 468 | usb_sndbulkpipe(serial->dev, endpoint) | dir, |
473 | buf, len, callback, ctx); | 469 | buf, len, callback, ctx); |
@@ -567,7 +563,6 @@ static void stop_urbs(struct usb_serial *serial) | |||
567 | struct usb_serial_port *port; | 563 | struct usb_serial_port *port; |
568 | struct usb_wwan_port_private *portdata; | 564 | struct usb_wwan_port_private *portdata; |
569 | 565 | ||
570 | /* Stop reading/writing urbs */ | ||
571 | for (i = 0; i < serial->num_ports; ++i) { | 566 | for (i = 0; i < serial->num_ports; ++i) { |
572 | port = serial->port[i]; | 567 | port = serial->port[i]; |
573 | portdata = usb_get_serial_port_data(port); | 568 | portdata = usb_get_serial_port_data(port); |
@@ -648,11 +643,9 @@ int usb_wwan_resume(struct usb_serial *serial) | |||
648 | 643 | ||
649 | spin_lock_irq(&intfdata->susp_lock); | 644 | spin_lock_irq(&intfdata->susp_lock); |
650 | for (i = 0; i < serial->num_ports; i++) { | 645 | for (i = 0; i < serial->num_ports; i++) { |
651 | /* walk all ports */ | ||
652 | port = serial->port[i]; | 646 | port = serial->port[i]; |
653 | portdata = usb_get_serial_port_data(port); | 647 | portdata = usb_get_serial_port_data(port); |
654 | 648 | ||
655 | /* skip closed ports */ | ||
656 | if (!portdata || !portdata->opened) | 649 | if (!portdata || !portdata->opened) |
657 | continue; | 650 | continue; |
658 | 651 | ||