diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2005-06-21 00:15:16 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-10-28 19:47:48 -0400 |
commit | 269bda1c123c7caf88e1deb2264f9086f0344192 (patch) | |
tree | c83d9944e0acdc40c9040cbccfb9ec7d606bdd2c /drivers/usb/serial/whiteheat.c | |
parent | 502b95c1cc9e2c855a26f90fc999c5211b8ba957 (diff) |
[PATCH] USB Serial: move name to driver structure
This fixes up a lot of problems in sysfs with some of the usb serial
drivers, they had incorrect driver names. Also saves a tiny ammount
of memory.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/whiteheat.c')
-rw-r--r-- | drivers/usb/serial/whiteheat.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c index fb95a34a1cf7..18c3183be769 100644 --- a/drivers/usb/serial/whiteheat.c +++ b/drivers/usb/serial/whiteheat.c | |||
@@ -159,9 +159,9 @@ static void whiteheat_write_callback (struct urb *urb, struct pt_regs *regs); | |||
159 | static struct usb_serial_driver whiteheat_fake_device = { | 159 | static struct usb_serial_driver whiteheat_fake_device = { |
160 | .driver = { | 160 | .driver = { |
161 | .owner = THIS_MODULE, | 161 | .owner = THIS_MODULE, |
162 | .name = "whiteheatnofirm", | ||
162 | }, | 163 | }, |
163 | .name = "Connect Tech - WhiteHEAT - (prerenumeration)", | 164 | .description = "Connect Tech - WhiteHEAT - (prerenumeration)", |
164 | .short_name = "whiteheatnofirm", | ||
165 | .id_table = id_table_prerenumeration, | 165 | .id_table = id_table_prerenumeration, |
166 | .num_interrupt_in = NUM_DONT_CARE, | 166 | .num_interrupt_in = NUM_DONT_CARE, |
167 | .num_bulk_in = NUM_DONT_CARE, | 167 | .num_bulk_in = NUM_DONT_CARE, |
@@ -174,9 +174,9 @@ static struct usb_serial_driver whiteheat_fake_device = { | |||
174 | static struct usb_serial_driver whiteheat_device = { | 174 | static struct usb_serial_driver whiteheat_device = { |
175 | .driver = { | 175 | .driver = { |
176 | .owner = THIS_MODULE, | 176 | .owner = THIS_MODULE, |
177 | .name = "whiteheat", | ||
177 | }, | 178 | }, |
178 | .name = "Connect Tech - WhiteHEAT", | 179 | .description = "Connect Tech - WhiteHEAT", |
179 | .short_name = "whiteheat", | ||
180 | .id_table = id_table_std, | 180 | .id_table = id_table_std, |
181 | .num_interrupt_in = NUM_DONT_CARE, | 181 | .num_interrupt_in = NUM_DONT_CARE, |
182 | .num_bulk_in = NUM_DONT_CARE, | 182 | .num_bulk_in = NUM_DONT_CARE, |
@@ -386,10 +386,10 @@ static int whiteheat_attach (struct usb_serial *serial) | |||
386 | usb_clear_halt(serial->dev, pipe); | 386 | usb_clear_halt(serial->dev, pipe); |
387 | ret = usb_bulk_msg (serial->dev, pipe, command, 2, &alen, COMMAND_TIMEOUT_MS); | 387 | ret = usb_bulk_msg (serial->dev, pipe, command, 2, &alen, COMMAND_TIMEOUT_MS); |
388 | if (ret) { | 388 | if (ret) { |
389 | err("%s: Couldn't send command [%d]", serial->type->name, ret); | 389 | err("%s: Couldn't send command [%d]", serial->type->description, ret); |
390 | goto no_firmware; | 390 | goto no_firmware; |
391 | } else if (alen != sizeof(command)) { | 391 | } else if (alen != sizeof(command)) { |
392 | err("%s: Send command incomplete [%d]", serial->type->name, alen); | 392 | err("%s: Send command incomplete [%d]", serial->type->description, alen); |
393 | goto no_firmware; | 393 | goto no_firmware; |
394 | } | 394 | } |
395 | 395 | ||
@@ -398,19 +398,19 @@ static int whiteheat_attach (struct usb_serial *serial) | |||
398 | usb_clear_halt(serial->dev, pipe); | 398 | usb_clear_halt(serial->dev, pipe); |
399 | ret = usb_bulk_msg (serial->dev, pipe, result, sizeof(*hw_info) + 1, &alen, COMMAND_TIMEOUT_MS); | 399 | ret = usb_bulk_msg (serial->dev, pipe, result, sizeof(*hw_info) + 1, &alen, COMMAND_TIMEOUT_MS); |
400 | if (ret) { | 400 | if (ret) { |
401 | err("%s: Couldn't get results [%d]", serial->type->name, ret); | 401 | err("%s: Couldn't get results [%d]", serial->type->description, ret); |
402 | goto no_firmware; | 402 | goto no_firmware; |
403 | } else if (alen != sizeof(result)) { | 403 | } else if (alen != sizeof(result)) { |
404 | err("%s: Get results incomplete [%d]", serial->type->name, alen); | 404 | err("%s: Get results incomplete [%d]", serial->type->description, alen); |
405 | goto no_firmware; | 405 | goto no_firmware; |
406 | } else if (result[0] != command[0]) { | 406 | } else if (result[0] != command[0]) { |
407 | err("%s: Command failed [%d]", serial->type->name, result[0]); | 407 | err("%s: Command failed [%d]", serial->type->description, result[0]); |
408 | goto no_firmware; | 408 | goto no_firmware; |
409 | } | 409 | } |
410 | 410 | ||
411 | hw_info = (struct whiteheat_hw_info *)&result[1]; | 411 | hw_info = (struct whiteheat_hw_info *)&result[1]; |
412 | 412 | ||
413 | info("%s: Driver %s: Firmware v%d.%02d", serial->type->name, | 413 | info("%s: Driver %s: Firmware v%d.%02d", serial->type->description, |
414 | DRIVER_VERSION, hw_info->sw_major_rev, hw_info->sw_minor_rev); | 414 | DRIVER_VERSION, hw_info->sw_major_rev, hw_info->sw_minor_rev); |
415 | 415 | ||
416 | for (i = 0; i < serial->num_ports; i++) { | 416 | for (i = 0; i < serial->num_ports; i++) { |
@@ -418,7 +418,7 @@ static int whiteheat_attach (struct usb_serial *serial) | |||
418 | 418 | ||
419 | info = (struct whiteheat_private *)kmalloc(sizeof(struct whiteheat_private), GFP_KERNEL); | 419 | info = (struct whiteheat_private *)kmalloc(sizeof(struct whiteheat_private), GFP_KERNEL); |
420 | if (info == NULL) { | 420 | if (info == NULL) { |
421 | err("%s: Out of memory for port structures\n", serial->type->name); | 421 | err("%s: Out of memory for port structures\n", serial->type->description); |
422 | goto no_private; | 422 | goto no_private; |
423 | } | 423 | } |
424 | 424 | ||
@@ -488,7 +488,7 @@ static int whiteheat_attach (struct usb_serial *serial) | |||
488 | 488 | ||
489 | command_info = (struct whiteheat_command_private *)kmalloc(sizeof(struct whiteheat_command_private), GFP_KERNEL); | 489 | command_info = (struct whiteheat_command_private *)kmalloc(sizeof(struct whiteheat_command_private), GFP_KERNEL); |
490 | if (command_info == NULL) { | 490 | if (command_info == NULL) { |
491 | err("%s: Out of memory for port structures\n", serial->type->name); | 491 | err("%s: Out of memory for port structures\n", serial->type->description); |
492 | goto no_command_private; | 492 | goto no_command_private; |
493 | } | 493 | } |
494 | 494 | ||
@@ -505,9 +505,9 @@ static int whiteheat_attach (struct usb_serial *serial) | |||
505 | 505 | ||
506 | no_firmware: | 506 | no_firmware: |
507 | /* Firmware likely not running */ | 507 | /* Firmware likely not running */ |
508 | err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->name); | 508 | err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description); |
509 | err("%s: If the firmware is not running (status led not blinking)\n", serial->type->name); | 509 | err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description); |
510 | err("%s: please contact support@connecttech.com\n", serial->type->name); | 510 | err("%s: please contact support@connecttech.com\n", serial->type->description); |
511 | return -ENODEV; | 511 | return -ENODEV; |
512 | 512 | ||
513 | no_command_private: | 513 | no_command_private: |