aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/kl5kusb105.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-14 12:47:43 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-14 12:47:43 -0400
commit1ad7604f69ae3c735e7537971f62b26e3807c18a (patch)
tree6da071e9f41c2bd06fadf42141b6ca2ded89d6fd /drivers/usb/serial/kl5kusb105.c
parentbfc51614b389f5c7a05181accfef38ccdd66661e (diff)
USB: serial: kl5kusb105.c: remove dbg() usage
dbg() was a very old USB-serial-specific macro. This patch removes it from being used in the driver and uses dev_dbg() instead. CC: Oliver Neukum <oliver@neukum.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/kl5kusb105.c')
-rw-r--r--drivers/usb/serial/kl5kusb105.c36
1 files changed, 18 insertions, 18 deletions
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 5bed59cd5776..73e0a23e14f3 100644
--- a/drivers/usb/serial/kl5kusb105.c
+++ b/drivers/usb/serial/kl5kusb105.c
@@ -239,7 +239,9 @@ static int klsi_105_startup(struct usb_serial *serial)
239 priv = kmalloc(sizeof(struct klsi_105_private), 239 priv = kmalloc(sizeof(struct klsi_105_private),
240 GFP_KERNEL); 240 GFP_KERNEL);
241 if (!priv) { 241 if (!priv) {
242 dbg("%skmalloc for klsi_105_private failed.", __func__); 242 dev_dbg(&serial->interface->dev,
243 "%s - kmalloc for klsi_105_private failed.\n",
244 __func__);
243 i--; 245 i--;
244 goto err_cleanup; 246 goto err_cleanup;
245 } 247 }
@@ -344,14 +346,14 @@ static int klsi_105_open(struct tty_struct *tty, struct usb_serial_port *port)
344 dev_err(&port->dev, "Enabling read failed (error = %d)\n", rc); 346 dev_err(&port->dev, "Enabling read failed (error = %d)\n", rc);
345 retval = rc; 347 retval = rc;
346 } else 348 } else
347 dbg("%s - enabled reading", __func__); 349 dev_dbg(&port->dev, "%s - enabled reading\n", __func__);
348 350
349 rc = klsi_105_get_line_state(port, &line_state); 351 rc = klsi_105_get_line_state(port, &line_state);
350 if (rc >= 0) { 352 if (rc >= 0) {
351 spin_lock_irqsave(&priv->lock, flags); 353 spin_lock_irqsave(&priv->lock, flags);
352 priv->line_state = line_state; 354 priv->line_state = line_state;
353 spin_unlock_irqrestore(&priv->lock, flags); 355 spin_unlock_irqrestore(&priv->lock, flags);
354 dbg("%s - read line state 0x%lx", __func__, line_state); 356 dev_dbg(&port->dev, "%s - read line state 0x%lx\n", __func__, line_state);
355 retval = 0; 357 retval = 0;
356 } else 358 } else
357 retval = rc; 359 retval = rc;
@@ -421,7 +423,7 @@ static void klsi_105_process_read_urb(struct urb *urb)
421 return; 423 return;
422 424
423 if (urb->actual_length <= KLSI_HDR_LEN) { 425 if (urb->actual_length <= KLSI_HDR_LEN) {
424 dbg("%s - malformed packet", __func__); 426 dev_dbg(&port->dev, "%s - malformed packet\n", __func__);
425 return; 427 return;
426 } 428 }
427 429
@@ -431,7 +433,7 @@ static void klsi_105_process_read_urb(struct urb *urb)
431 433
432 len = get_unaligned_le16(data); 434 len = get_unaligned_le16(data);
433 if (len > urb->actual_length - KLSI_HDR_LEN) { 435 if (len > urb->actual_length - KLSI_HDR_LEN) {
434 dbg("%s - packet length mismatch", __func__); 436 dev_dbg(&port->dev, "%s - packet length mismatch\n", __func__);
435 len = urb->actual_length - KLSI_HDR_LEN; 437 len = urb->actual_length - KLSI_HDR_LEN;
436 } 438 }
437 439
@@ -445,6 +447,7 @@ static void klsi_105_set_termios(struct tty_struct *tty,
445 struct ktermios *old_termios) 447 struct ktermios *old_termios)
446{ 448{
447 struct klsi_105_private *priv = usb_get_serial_port_data(port); 449 struct klsi_105_private *priv = usb_get_serial_port_data(port);
450 struct device *dev = &port->dev;
448 unsigned int iflag = tty->termios->c_iflag; 451 unsigned int iflag = tty->termios->c_iflag;
449 unsigned int old_iflag = old_termios->c_iflag; 452 unsigned int old_iflag = old_termios->c_iflag;
450 unsigned int cflag = tty->termios->c_cflag; 453 unsigned int cflag = tty->termios->c_cflag;
@@ -455,8 +458,7 @@ static void klsi_105_set_termios(struct tty_struct *tty,
455 458
456 cfg = kmalloc(sizeof(*cfg), GFP_KERNEL); 459 cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
457 if (!cfg) { 460 if (!cfg) {
458 dev_err(&port->dev, "%s - out of memory for config buffer.\n", 461 dev_err(dev, "%s - out of memory for config buffer.\n", __func__);
459 __func__);
460 return; 462 return;
461 } 463 }
462 464
@@ -471,7 +473,7 @@ static void klsi_105_set_termios(struct tty_struct *tty,
471 if ((cflag & CBAUD) != (old_cflag & CBAUD)) { 473 if ((cflag & CBAUD) != (old_cflag & CBAUD)) {
472 /* reassert DTR and (maybe) RTS on transition from B0 */ 474 /* reassert DTR and (maybe) RTS on transition from B0 */
473 if ((old_cflag & CBAUD) == B0) { 475 if ((old_cflag & CBAUD) == B0) {
474 dbg("%s: baud was B0", __func__); 476 dev_dbg(dev, "%s: baud was B0\n", __func__);
475#if 0 477#if 0
476 priv->control_state |= TIOCM_DTR; 478 priv->control_state |= TIOCM_DTR;
477 /* don't set RTS if using hardware flow control */ 479 /* don't set RTS if using hardware flow control */
@@ -509,14 +511,13 @@ static void klsi_105_set_termios(struct tty_struct *tty,
509 priv->cfg.baudrate = kl5kusb105a_sio_b115200; 511 priv->cfg.baudrate = kl5kusb105a_sio_b115200;
510 break; 512 break;
511 default: 513 default:
512 dbg("KLSI USB->Serial converter:" 514 dev_dbg(dev, "KLSI USB->Serial converter: unsupported baudrate request, using default of 9600");
513 " unsupported baudrate request, using default of 9600"); 515 priv->cfg.baudrate = kl5kusb105a_sio_b9600;
514 priv->cfg.baudrate = kl5kusb105a_sio_b9600;
515 baud = 9600; 516 baud = 9600;
516 break; 517 break;
517 } 518 }
518 if ((cflag & CBAUD) == B0) { 519 if ((cflag & CBAUD) == B0) {
519 dbg("%s: baud is B0", __func__); 520 dev_dbg(dev, "%s: baud is B0\n", __func__);
520 /* Drop RTS and DTR */ 521 /* Drop RTS and DTR */
521 /* maybe this should be simulated by sending read 522 /* maybe this should be simulated by sending read
522 * disable and read enable messages? 523 * disable and read enable messages?
@@ -533,11 +534,11 @@ static void klsi_105_set_termios(struct tty_struct *tty,
533 /* set the number of data bits */ 534 /* set the number of data bits */
534 switch (cflag & CSIZE) { 535 switch (cflag & CSIZE) {
535 case CS5: 536 case CS5:
536 dbg("%s - 5 bits/byte not supported", __func__); 537 dev_dbg(dev, "%s - 5 bits/byte not supported\n", __func__);
537 spin_unlock_irqrestore(&priv->lock, flags); 538 spin_unlock_irqrestore(&priv->lock, flags);
538 goto err; 539 goto err;
539 case CS6: 540 case CS6:
540 dbg("%s - 6 bits/byte not supported", __func__); 541 dev_dbg(dev, "%s - 6 bits/byte not supported\n", __func__);
541 spin_unlock_irqrestore(&priv->lock, flags); 542 spin_unlock_irqrestore(&priv->lock, flags);
542 goto err; 543 goto err;
543 case CS7: 544 case CS7:
@@ -547,8 +548,7 @@ static void klsi_105_set_termios(struct tty_struct *tty,
547 priv->cfg.databits = kl5kusb105a_dtb_8; 548 priv->cfg.databits = kl5kusb105a_dtb_8;
548 break; 549 break;
549 default: 550 default:
550 dev_err(&port->dev, 551 dev_err(dev, "CSIZE was not CS5-CS8, using default of 8\n");
551 "CSIZE was not CS5-CS8, using default of 8\n");
552 priv->cfg.databits = kl5kusb105a_dtb_8; 552 priv->cfg.databits = kl5kusb105a_dtb_8;
553 break; 553 break;
554 } 554 }
@@ -616,7 +616,7 @@ static void mct_u232_break_ctl(struct tty_struct *tty, int break_state)
616 (struct mct_u232_private *)port->private; 616 (struct mct_u232_private *)port->private;
617 unsigned char lcr = priv->last_lcr; 617 unsigned char lcr = priv->last_lcr;
618 618
619 dbg("%sstate=%d", __func__, break_state); 619 dev_dbg(&port->dev, "%s - state=%d\n", __func__, break_state);
620 620
621 /* LOCKING */ 621 /* LOCKING */
622 if (break_state) 622 if (break_state)
@@ -645,7 +645,7 @@ static int klsi_105_tiocmget(struct tty_struct *tty)
645 spin_lock_irqsave(&priv->lock, flags); 645 spin_lock_irqsave(&priv->lock, flags);
646 priv->line_state = line_state; 646 priv->line_state = line_state;
647 spin_unlock_irqrestore(&priv->lock, flags); 647 spin_unlock_irqrestore(&priv->lock, flags);
648 dbg("%s - read line state 0x%lx", __func__, line_state); 648 dev_dbg(&port->dev, "%s - read line state 0x%lx\n", __func__, line_state);
649 return (int)line_state; 649 return (int)line_state;
650} 650}
651 651