aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/ipaq.c
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-04-19 18:13:59 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-04-19 18:17:46 -0400
commitcae18768acf684b505c928e5cf7ea741fac45b83 (patch)
treeaaa823eda64876a8d66121e7db792f6a48bee738 /drivers/usb/serial/ipaq.c
parent0bf4da35b5236b585f8e4531c604accd36ed9bc2 (diff)
USB: serial: ipaq: remove product and vendor module parameters
This driver is for devices that are no longer being made, so the ability to add new device ids when loading the module is not a feature that anyone uses anymore. So remove it, which simplifies the startup code a lot, and saves space. If you still need to dynamically load device ids, that can be done through sysfs. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/ipaq.c')
-rw-r--r--drivers/usb/serial/ipaq.c33
1 files changed, 1 insertions, 32 deletions
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index 10c02b8b5664..bd4912f4eaf4 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -33,7 +33,6 @@
33#define DRIVER_AUTHOR "Ganesh Varadarajan <ganesh@veritas.com>" 33#define DRIVER_AUTHOR "Ganesh Varadarajan <ganesh@veritas.com>"
34#define DRIVER_DESC "USB PocketPC PDA driver" 34#define DRIVER_DESC "USB PocketPC PDA driver"
35 35
36static __u16 product, vendor;
37static bool debug; 36static bool debug;
38static int connect_retries = KP_RETRIES; 37static int connect_retries = KP_RETRIES;
39static int initial_wait; 38static int initial_wait;
@@ -45,7 +44,6 @@ static int ipaq_calc_num_ports(struct usb_serial *serial);
45static int ipaq_startup(struct usb_serial *serial); 44static int ipaq_startup(struct usb_serial *serial);
46 45
47static struct usb_device_id ipaq_id_table [] = { 46static struct usb_device_id ipaq_id_table [] = {
48 /* The first entry is a placeholder for the insmod-specified device */
49 { USB_DEVICE(0x049F, 0x0003) }, 47 { USB_DEVICE(0x049F, 0x0003) },
50 { USB_DEVICE(0x0104, 0x00BE) }, /* Socket USB Sync */ 48 { USB_DEVICE(0x0104, 0x00BE) }, /* Socket USB Sync */
51 { USB_DEVICE(0x03F0, 0x1016) }, /* HP USB Sync */ 49 { USB_DEVICE(0x03F0, 0x1016) }, /* HP USB Sync */
@@ -623,30 +621,7 @@ static int ipaq_startup(struct usb_serial *serial)
623 return usb_reset_configuration(serial->dev); 621 return usb_reset_configuration(serial->dev);
624} 622}
625 623
626static int __init ipaq_init(void) 624module_usb_serial_driver(ipaq_driver, serial_drivers);
627{
628 int retval;
629
630 if (vendor) {
631 ipaq_id_table[0].idVendor = vendor;
632 ipaq_id_table[0].idProduct = product;
633 }
634
635 retval = usb_serial_register_drivers(&ipaq_driver, serial_drivers);
636 if (retval == 0)
637 printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
638 DRIVER_DESC "\n");
639 return retval;
640}
641
642static void __exit ipaq_exit(void)
643{
644 usb_serial_deregister_drivers(&ipaq_driver, serial_drivers);
645}
646
647
648module_init(ipaq_init);
649module_exit(ipaq_exit);
650 625
651MODULE_AUTHOR(DRIVER_AUTHOR); 626MODULE_AUTHOR(DRIVER_AUTHOR);
652MODULE_DESCRIPTION(DRIVER_DESC); 627MODULE_DESCRIPTION(DRIVER_DESC);
@@ -655,12 +630,6 @@ MODULE_LICENSE("GPL");
655module_param(debug, bool, S_IRUGO | S_IWUSR); 630module_param(debug, bool, S_IRUGO | S_IWUSR);
656MODULE_PARM_DESC(debug, "Debug enabled or not"); 631MODULE_PARM_DESC(debug, "Debug enabled or not");
657 632
658module_param(vendor, ushort, 0);
659MODULE_PARM_DESC(vendor, "User specified USB idVendor");
660
661module_param(product, ushort, 0);
662MODULE_PARM_DESC(product, "User specified USB idProduct");
663
664module_param(connect_retries, int, S_IRUGO|S_IWUSR); 633module_param(connect_retries, int, S_IRUGO|S_IWUSR);
665MODULE_PARM_DESC(connect_retries, 634MODULE_PARM_DESC(connect_retries,
666 "Maximum number of connect retries (one second each)"); 635 "Maximum number of connect retries (one second each)");