USB: remove use of err() in drivers/usb/serial

err() is going away, so switch to dev_err() or printk() if it's really
needed.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 17 insertions, 17 deletions

diff --git a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
index bb19f1c2e0d3..b7eacad4d48c 100644
--- a/drivers/usb/serial/belkin_sa.c
+++ b/drivers/usb/serial/belkin_sa.c
@@ -228,7 +228,7 @@ static int  belkin_sa_open(struct tty_struct *tty,
         port->read_urb->dev = port->serial->dev;
         retval = usb_submit_urb(port->read_urb, GFP_KERNEL);
         if (retval) {
-                err("usb_submit_urb(read bulk) failed");
+                dev_err(&port->dev, "usb_submit_urb(read bulk) failed\n");
                 goto exit;
         }
 
@@ -236,7 +236,7 @@ static int  belkin_sa_open(struct tty_struct *tty,
         retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
         if (retval) {
                 usb_kill_urb(port->read_urb);
-                err(" usb_submit_urb(read int) failed");
+                dev_err(&port->dev, "usb_submit_urb(read int) failed\n");
         }
 
 exit:
@@ -342,8 +342,8 @@ static void belkin_sa_read_int_callback(struct urb *urb)
 exit:
         retval = usb_submit_urb(urb, GFP_ATOMIC);
         if (retval)
-                err("%s - usb_submit_urb failed with result %d",
-                     __func__, retval);
+                dev_err(&port->dev, "%s - usb_submit_urb failed with "
+                        "result %d\n", __func__, retval);
 }
 
 static void belkin_sa_set_termios(struct tty_struct *tty,
@@ -382,12 +382,12 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                 if ((old_cflag & CBAUD) == B0) {
                         control_state |= (TIOCM_DTR|TIOCM_RTS);
                         if (BSA_USB_CMD(BELKIN_SA_SET_DTR_REQUEST, 1) < 0)
-                                err("Set DTR error");
+                                dev_err(&port->dev, "Set DTR error\n");
                         /* don't set RTS if using hardware flow control */
                         if (!(old_cflag & CRTSCTS))
                                 if (BSA_USB_CMD(BELKIN_SA_SET_RTS_REQUEST
                                                                 , 1) < 0)
-                                        err("Set RTS error");
+                                        dev_err(&port->dev, "Set RTS error\n");
                 }
         }
 
@@ -403,18 +403,18 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                 /* Report the actual baud rate back to the caller */
                 tty_encode_baud_rate(tty, baud, baud);
                 if (BSA_USB_CMD(BELKIN_SA_SET_BAUDRATE_REQUEST, urb_value) < 0)
-                        err("Set baudrate error");
+                        dev_err(&port->dev, "Set baudrate error\n");
         } else {
                 /* Disable flow control */
                 if (BSA_USB_CMD(BELKIN_SA_SET_FLOW_CTRL_REQUEST,
                                                 BELKIN_SA_FLOW_NONE) < 0)
-                        err("Disable flowcontrol error");
+                        dev_err(&port->dev, "Disable flowcontrol error\n");
                 /* Drop RTS and DTR */
                 control_state &= ~(TIOCM_DTR | TIOCM_RTS);
                 if (BSA_USB_CMD(BELKIN_SA_SET_DTR_REQUEST, 0) < 0)
-                        err("DTR LOW error");
+                        dev_err(&port->dev, "DTR LOW error\n");
                 if (BSA_USB_CMD(BELKIN_SA_SET_RTS_REQUEST, 0) < 0)
-                        err("RTS LOW error");
+                        dev_err(&port->dev, "RTS LOW error\n");
         }
 
         /* set the parity */
@@ -425,7 +425,7 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                 else
                         urb_value = BELKIN_SA_PARITY_NONE;
                 if (BSA_USB_CMD(BELKIN_SA_SET_PARITY_REQUEST, urb_value) < 0)
-                        err("Set parity error");
+                        dev_err(&port->dev, "Set parity error\n");
         }
 
         /* set the number of data bits */
@@ -448,7 +448,7 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                         break;
                 }
                 if (BSA_USB_CMD(BELKIN_SA_SET_DATA_BITS_REQUEST, urb_value) < 0)
-                        err("Set data bits error");
+                        dev_err(&port->dev, "Set data bits error\n");
         }
 
         /* set the number of stop bits */
@@ -457,7 +457,7 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                                                 : BELKIN_SA_STOP_BITS(1);
                 if (BSA_USB_CMD(BELKIN_SA_SET_STOP_BITS_REQUEST,
                                                         urb_value) < 0)
-                        err("Set stop bits error");
+                        dev_err(&port->dev, "Set stop bits error\n");
         }
 
         /* Set flow control */
@@ -478,7 +478,7 @@ static void belkin_sa_set_termios(struct tty_struct *tty,
                         urb_value &= ~(BELKIN_SA_FLOW_IRTS);
 
                 if (BSA_USB_CMD(BELKIN_SA_SET_FLOW_CTRL_REQUEST, urb_value) < 0)
-                        err("Set flow control error");
+                        dev_err(&port->dev, "Set flow control error\n");
         }
 
         /* save off the modified port settings */
@@ -494,7 +494,7 @@ static void belkin_sa_break_ctl(struct tty_struct *tty, int break_state)
         struct usb_serial *serial = port->serial;
 
         if (BSA_USB_CMD(BELKIN_SA_SET_BREAK_REQUEST, break_state ? 1 : 0) < 0)
-                err("Set break_ctl %d", break_state);
+                dev_err(&port->dev, "Set break_ctl %d\n", break_state);
 }
 
 
@@ -554,13 +554,13 @@ static int belkin_sa_tiocmset(struct tty_struct *tty, struct file *file,
 
         retval = BSA_USB_CMD(BELKIN_SA_SET_RTS_REQUEST, rts);
         if (retval < 0) {
-                err("Set RTS error %d", retval);
+                dev_err(&port->dev, "Set RTS error %d\n", retval);
                 goto exit;
         }
 
         retval = BSA_USB_CMD(BELKIN_SA_SET_DTR_REQUEST, dtr);
         if (retval < 0) {
-                err("Set DTR error %d", retval);
+                dev_err(&port->dev, "Set DTR error %d\n", retval);
                 goto exit;
         }
 exit: