diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2012-09-06 14:11:19 -0400 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2012-09-10 09:12:59 -0400 |
commit | 3b4a3fc0ba83265c0bfcfdfc3416e65e47441747 (patch) | |
tree | 6b9dc65f08622c1f1e717d199ab3262d9755d5a3 /drivers/usb/gadget/Makefile | |
parent | 18786da4853017d983ff6911648543ca617c12d1 (diff) |
usb: gadget: move usb_gadget_controller_number() into a .c file and libcomposite
After I moved the function from the header file to the c file I see:
| $ size drivers/usb/gadget/gadget_chips.o
| text data bss dec hex filename
| 1048 0 0 1048 418 drivers/usb/gadget/gadget_chips.o
That is almost a KiB which is removed from each user.
As Felipe pointed out, the function / usage is very dumb actually. This is
used for the following reasons:
- epautoconf ep hint (could provide a per-gadget callback)
- miss-features. currently the missing altsetting on pxa's and something
ZLP related on musbhdrc (looks like an optimisation which could be
implemented in musb itself if it is correct)
- unique BCD accross all UDCs. Not sure how important this is.
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget/Makefile')
-rw-r--r-- | drivers/usb/gadget/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile index 23d705f194ac..4fec0e8ee000 100644 --- a/drivers/usb/gadget/Makefile +++ b/drivers/usb/gadget/Makefile | |||
@@ -5,7 +5,7 @@ ccflags-$(CONFIG_USB_GADGET_DEBUG) := -DDEBUG | |||
5 | 5 | ||
6 | obj-$(CONFIG_USB_GADGET) += udc-core.o | 6 | obj-$(CONFIG_USB_GADGET) += udc-core.o |
7 | obj-$(CONFIG_USB_LIBCOMPOSITE) += libcomposite.o | 7 | obj-$(CONFIG_USB_LIBCOMPOSITE) += libcomposite.o |
8 | libcomposite-y := usbstring.o config.o epautoconf.o | 8 | libcomposite-y := usbstring.o config.o epautoconf.o gadget_chips.o |
9 | obj-$(CONFIG_USB_DUMMY_HCD) += dummy_hcd.o | 9 | obj-$(CONFIG_USB_DUMMY_HCD) += dummy_hcd.o |
10 | obj-$(CONFIG_USB_NET2272) += net2272.o | 10 | obj-$(CONFIG_USB_NET2272) += net2272.o |
11 | obj-$(CONFIG_USB_NET2280) += net2280.o | 11 | obj-$(CONFIG_USB_NET2280) += net2280.o |