aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc3
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2012-01-18 10:06:03 -0500
committerFelipe Balbi <balbi@ti.com>2012-02-06 04:48:28 -0500
commit40aa41fba348bc5bd19ff5bcf2b03d67bb01d1ce (patch)
tree81cb72779547b8530e6b28c9f7c59d0e599ef113 /drivers/usb/dwc3
parent138801aaa566ecb5a5739a85909b9ec7285efd70 (diff)
usb: dwc3: gadget: fix XferNotReady debug print
Only bit 3 of the event status bitfield is valid and the others should not be considered. Make sure SW matches documentation on that case to avoid bogus debugging prints which would confuse an engineer. Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc3')
-rw-r--r--drivers/usb/dwc3/core.h5
-rw-r--r--drivers/usb/dwc3/gadget.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 9e57f8e9bf17..f4878c4dec0f 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -719,6 +719,11 @@ struct dwc3_event_depevt {
719 u32 endpoint_event:4; 719 u32 endpoint_event:4;
720 u32 reserved11_10:2; 720 u32 reserved11_10:2;
721 u32 status:4; 721 u32 status:4;
722
723/* Within XferNotReady */
724#define DEPEVT_STATUS_TRANSFER_ACTIVE (1 << 3)
725
726/* Within XferComplete */
722#define DEPEVT_STATUS_BUSERR (1 << 0) 727#define DEPEVT_STATUS_BUSERR (1 << 0)
723#define DEPEVT_STATUS_SHORT (1 << 1) 728#define DEPEVT_STATUS_SHORT (1 << 1)
724#define DEPEVT_STATUS_IOC (1 << 2) 729#define DEPEVT_STATUS_IOC (1 << 2)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index e0e2337dad13..4b64dc0bfa27 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1657,7 +1657,8 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
1657 int ret; 1657 int ret;
1658 1658
1659 dev_vdbg(dwc->dev, "%s: reason %s\n", 1659 dev_vdbg(dwc->dev, "%s: reason %s\n",
1660 dep->name, event->status 1660 dep->name, event->status &
1661 DEPEVT_STATUS_TRANSFER_ACTIVE
1661 ? "Transfer Active" 1662 ? "Transfer Active"
1662 : "Transfer Not Active"); 1663 : "Transfer Not Active");
1663 1664