aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc3/core.c
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>2011-08-29 07:56:36 -0400
committerFelipe Balbi <balbi@ti.com>2011-09-09 06:02:09 -0400
commit7650bd74d3441907867276dc381b2ee0dc355c65 (patch)
treec3478d45ed646a0bf5b3dd18fd8f0f8902ce40ff /drivers/usb/dwc3/core.c
parente7225315a89731d0f986c20165184f1dc9a9bf2b (diff)
usb: dwc3: core: move the core check before soft reset
We read the DWC3_GSNPSID register to make sure we got the correct register offset passed. One of the recent commits moved the soft reset before this so in case of the wrong offset we end up with "reset timed out". This patch moves the "id" check before the reset again. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc3/core.c')
-rw-r--r--drivers/usb/dwc3/core.c19
1 files changed, 9 insertions, 10 deletions
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 443e4fb9b8f3..6aa091339989 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -241,6 +241,15 @@ static int __devinit dwc3_core_init(struct dwc3 *dwc)
241 u32 reg; 241 u32 reg;
242 int ret; 242 int ret;
243 243
244 reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
245 /* This should read as U3 followed by revision number */
246 if ((reg & DWC3_GSNPSID_MASK) != 0x55330000) {
247 dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
248 ret = -ENODEV;
249 goto err0;
250 }
251 dwc->revision = reg & DWC3_GSNPSREV_MASK;
252
244 dwc3_core_soft_reset(dwc); 253 dwc3_core_soft_reset(dwc);
245 254
246 /* issue device SoftReset too */ 255 /* issue device SoftReset too */
@@ -260,16 +269,6 @@ static int __devinit dwc3_core_init(struct dwc3 *dwc)
260 cpu_relax(); 269 cpu_relax();
261 } while (true); 270 } while (true);
262 271
263 reg = dwc3_readl(dwc->regs, DWC3_GSNPSID);
264 /* This should read as U3 followed by revision number */
265 if ((reg & DWC3_GSNPSID_MASK) != 0x55330000) {
266 dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
267 ret = -ENODEV;
268 goto err0;
269 }
270
271 dwc->revision = reg & DWC3_GSNPSREV_MASK;
272
273 ret = dwc3_alloc_event_buffers(dwc, DWC3_EVENT_BUFFERS_NUM, 272 ret = dwc3_alloc_event_buffers(dwc, DWC3_EVENT_BUFFERS_NUM,
274 DWC3_EVENT_BUFFERS_SIZE); 273 DWC3_EVENT_BUFFERS_SIZE);
275 if (ret) { 274 if (ret) {