aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc2
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2014-10-17 13:05:12 -0400
committerFelipe Balbi <balbi@ti.com>2014-11-03 11:01:16 -0500
commit22835b807e7ca946a4d1fbd4c7af56aa09cd273e (patch)
tree2b96d92ea6dbaadf7880c9729e5bfb3cb3265978 /drivers/usb/dwc2
parent8da9fe8af8e3fd953b346c800976a5db6c0115a4 (diff)
usb: gadget: remove unnecessary 'driver' argument
now that no UDC driver relies on the extra 'driver' argument to ->udc_stop(), we can safely remove it. This commit is based on previous work by Robert Baldyga <r.baldyga@samsung.com> which can be found at [1]; however that patch turned out to have a high probability of regressing many UDC drivers because of a blind search & replace s/driver/$udc->driver/ which caused the 'driver' argument to stop_activity() to be a valid non-NULL pointer when it should be NULL, thus causing UDCs to mistakenly call gadget driver's ->disconnect() callback. [1] http://markmail.org/message/x5zneg4xea4zntab Acked-by: Peter Chen <peter.chen@freescale.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc2')
-rw-r--r--drivers/usb/dwc2/gadget.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index eee87098bb8b..441f1c4b8eb4 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2921,8 +2921,7 @@ err:
2921 * 2921 *
2922 * Stop udc hw block and stay tunned for future transmissions 2922 * Stop udc hw block and stay tunned for future transmissions
2923 */ 2923 */
2924static int s3c_hsotg_udc_stop(struct usb_gadget *gadget, 2924static int s3c_hsotg_udc_stop(struct usb_gadget *gadget)
2925 struct usb_gadget_driver *driver)
2926{ 2925{
2927 struct s3c_hsotg *hsotg = to_hsotg(gadget); 2926 struct s3c_hsotg *hsotg = to_hsotg(gadget);
2928 unsigned long flags = 0; 2927 unsigned long flags = 0;