diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2011-08-23 06:12:03 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-08-23 12:47:40 -0400 |
commit | 29cc88979a8818cd8c5019426e945aed118b400e (patch) | |
tree | 849401ad869d09ce45dd7a3fadd7eb71b1e9fcbd /drivers/usb/core | |
parent | 46a57283e86c68351377ac3349f1465aee938fbd (diff) |
USB: use usb_endpoint_maxp() instead of le16_to_cpu()
Now ${LINUX}/drivers/usb/* can use usb_endpoint_maxp(desc) to get maximum packet size
instead of le16_to_cpu(desc->wMaxPacketSize).
This patch fix it up
Cc: Armin Fuerst <fuerst@in.tum.de>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Johannes Erdfelt <johannes@erdfelt.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: David Kubicek <dave@awk.cz>
Cc: Johan Hovold <jhovold@gmail.com>
Cc: Brad Hards <bhards@bigpond.net.au>
Acked-by: Felipe Balbi <balbi@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Dahlmann <dahlmann.thomas@arcor.de>
Cc: David Brownell <david-b@pacbell.net>
Cc: David Lopo <dlopo@chipidea.mips.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: Xie Xiaobo <X.Xie@freescale.com>
Cc: Li Yang <leoli@freescale.com>
Cc: Jiang Bo <tanya.jiang@freescale.com>
Cc: Yuan-hsin Chen <yhchen@faraday-tech.com>
Cc: Darius Augulis <augulis.darius@gmail.com>
Cc: Xiaochen Shen <xiaochen.shen@intel.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: OKI SEMICONDUCTOR, <toshiharu-linux@dsn.okisemi.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Ben Dooks <ben@simtec.co.uk>
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: Herbert Pƶtzl <herbert@13thfloor.at>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Roman Weissgaerber <weissg@vienna.at>
Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Tony Olech <tony.olech@elandigitalsystems.com>
Cc: Florian Floe Echtler <echtler@fs.tum.de>
Cc: Christian Lucht <lucht@codemercs.com>
Cc: Juergen Stuber <starblue@sourceforge.net>
Cc: Georges Toth <g.toth@e-biz.lu>
Cc: Bill Ryder <bryder@sgi.com>
Cc: Kuba Ober <kuba@mareimbrium.org>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/core')
-rw-r--r-- | drivers/usb/core/config.c | 8 | ||||
-rw-r--r-- | drivers/usb/core/devices.c | 4 | ||||
-rw-r--r-- | drivers/usb/core/endpoint.c | 2 | ||||
-rw-r--r-- | drivers/usb/core/hub.c | 2 | ||||
-rw-r--r-- | drivers/usb/core/urb.c | 2 |
5 files changed, 9 insertions, 9 deletions
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index 26678cadfb21..9d5e07af55be 100644 --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c | |||
@@ -124,9 +124,9 @@ static void usb_parse_ss_endpoint_companion(struct device *ddev, int cfgno, | |||
124 | 124 | ||
125 | if (usb_endpoint_xfer_isoc(&ep->desc)) | 125 | if (usb_endpoint_xfer_isoc(&ep->desc)) |
126 | max_tx = (desc->bMaxBurst + 1) * (desc->bmAttributes + 1) * | 126 | max_tx = (desc->bMaxBurst + 1) * (desc->bmAttributes + 1) * |
127 | le16_to_cpu(ep->desc.wMaxPacketSize); | 127 | usb_endpoint_maxp(&ep->desc); |
128 | else if (usb_endpoint_xfer_int(&ep->desc)) | 128 | else if (usb_endpoint_xfer_int(&ep->desc)) |
129 | max_tx = le16_to_cpu(ep->desc.wMaxPacketSize) * | 129 | max_tx = usb_endpoint_maxp(&ep->desc) * |
130 | (desc->bMaxBurst + 1); | 130 | (desc->bMaxBurst + 1); |
131 | else | 131 | else |
132 | max_tx = 999999; | 132 | max_tx = 999999; |
@@ -241,7 +241,7 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum, | |||
241 | cfgno, inum, asnum, d->bEndpointAddress); | 241 | cfgno, inum, asnum, d->bEndpointAddress); |
242 | endpoint->desc.bmAttributes = USB_ENDPOINT_XFER_INT; | 242 | endpoint->desc.bmAttributes = USB_ENDPOINT_XFER_INT; |
243 | endpoint->desc.bInterval = 1; | 243 | endpoint->desc.bInterval = 1; |
244 | if (le16_to_cpu(endpoint->desc.wMaxPacketSize) > 8) | 244 | if (usb_endpoint_maxp(&endpoint->desc) > 8) |
245 | endpoint->desc.wMaxPacketSize = cpu_to_le16(8); | 245 | endpoint->desc.wMaxPacketSize = cpu_to_le16(8); |
246 | } | 246 | } |
247 | 247 | ||
@@ -254,7 +254,7 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum, | |||
254 | && usb_endpoint_xfer_bulk(d)) { | 254 | && usb_endpoint_xfer_bulk(d)) { |
255 | unsigned maxp; | 255 | unsigned maxp; |
256 | 256 | ||
257 | maxp = le16_to_cpu(endpoint->desc.wMaxPacketSize) & 0x07ff; | 257 | maxp = usb_endpoint_maxp(&endpoint->desc) & 0x07ff; |
258 | if (maxp != 512) | 258 | if (maxp != 512) |
259 | dev_warn(ddev, "config %d interface %d altsetting %d " | 259 | dev_warn(ddev, "config %d interface %d altsetting %d " |
260 | "bulk endpoint 0x%X has invalid maxpacket %d\n", | 260 | "bulk endpoint 0x%X has invalid maxpacket %d\n", |
diff --git a/drivers/usb/core/devices.c b/drivers/usb/core/devices.c index 0149c0976e9c..d95696584762 100644 --- a/drivers/usb/core/devices.c +++ b/drivers/usb/core/devices.c | |||
@@ -190,7 +190,7 @@ static char *usb_dump_endpoint_descriptor(int speed, char *start, char *end, | |||
190 | dir = usb_endpoint_dir_in(desc) ? 'I' : 'O'; | 190 | dir = usb_endpoint_dir_in(desc) ? 'I' : 'O'; |
191 | 191 | ||
192 | if (speed == USB_SPEED_HIGH) { | 192 | if (speed == USB_SPEED_HIGH) { |
193 | switch (le16_to_cpu(desc->wMaxPacketSize) & (0x03 << 11)) { | 193 | switch (usb_endpoint_maxp(desc) & (0x03 << 11)) { |
194 | case 1 << 11: | 194 | case 1 << 11: |
195 | bandwidth = 2; break; | 195 | bandwidth = 2; break; |
196 | case 2 << 11: | 196 | case 2 << 11: |
@@ -240,7 +240,7 @@ static char *usb_dump_endpoint_descriptor(int speed, char *start, char *end, | |||
240 | 240 | ||
241 | start += sprintf(start, format_endpt, desc->bEndpointAddress, dir, | 241 | start += sprintf(start, format_endpt, desc->bEndpointAddress, dir, |
242 | desc->bmAttributes, type, | 242 | desc->bmAttributes, type, |
243 | (le16_to_cpu(desc->wMaxPacketSize) & 0x07ff) * | 243 | (usb_endpoint_maxp(desc) & 0x07ff) * |
244 | bandwidth, | 244 | bandwidth, |
245 | interval, unit); | 245 | interval, unit); |
246 | return start; | 246 | return start; |
diff --git a/drivers/usb/core/endpoint.c b/drivers/usb/core/endpoint.c index df502a98d0df..db7fe50c23d4 100644 --- a/drivers/usb/core/endpoint.c +++ b/drivers/usb/core/endpoint.c | |||
@@ -56,7 +56,7 @@ static ssize_t show_ep_wMaxPacketSize(struct device *dev, | |||
56 | { | 56 | { |
57 | struct ep_device *ep = to_ep_device(dev); | 57 | struct ep_device *ep = to_ep_device(dev); |
58 | return sprintf(buf, "%04x\n", | 58 | return sprintf(buf, "%04x\n", |
59 | le16_to_cpu(ep->desc->wMaxPacketSize) & 0x07ff); | 59 | usb_endpoint_maxp(ep->desc) & 0x07ff); |
60 | } | 60 | } |
61 | static DEVICE_ATTR(wMaxPacketSize, S_IRUGO, show_ep_wMaxPacketSize, NULL); | 61 | static DEVICE_ATTR(wMaxPacketSize, S_IRUGO, show_ep_wMaxPacketSize, NULL); |
62 | 62 | ||
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 99fff6be3641..338f91ff54cb 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c | |||
@@ -3018,7 +3018,7 @@ hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1, | |||
3018 | i = 512; | 3018 | i = 512; |
3019 | else | 3019 | else |
3020 | i = udev->descriptor.bMaxPacketSize0; | 3020 | i = udev->descriptor.bMaxPacketSize0; |
3021 | if (le16_to_cpu(udev->ep0.desc.wMaxPacketSize) != i) { | 3021 | if (usb_endpoint_maxp(&udev->ep0.desc) != i) { |
3022 | if (udev->speed == USB_SPEED_LOW || | 3022 | if (udev->speed == USB_SPEED_LOW || |
3023 | !(i == 8 || i == 16 || i == 32 || i == 64)) { | 3023 | !(i == 8 || i == 16 || i == 32 || i == 64)) { |
3024 | dev_err(&udev->dev, "Invalid ep0 maxpacket: %d\n", i); | 3024 | dev_err(&udev->dev, "Invalid ep0 maxpacket: %d\n", i); |
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index ae334b067c13..909625b91eb3 100644 --- a/drivers/usb/core/urb.c +++ b/drivers/usb/core/urb.c | |||
@@ -350,7 +350,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags) | |||
350 | dev->state < USB_STATE_CONFIGURED) | 350 | dev->state < USB_STATE_CONFIGURED) |
351 | return -ENODEV; | 351 | return -ENODEV; |
352 | 352 | ||
353 | max = le16_to_cpu(ep->desc.wMaxPacketSize); | 353 | max = usb_endpoint_maxp(&ep->desc); |
354 | if (max <= 0) { | 354 | if (max <= 0) { |
355 | dev_dbg(&dev->dev, | 355 | dev_dbg(&dev->dev, |
356 | "bogus endpoint ep%d%s in %s (bad maxpacket %d)\n", | 356 | "bogus endpoint ep%d%s in %s (bad maxpacket %d)\n", |