USB: cdc-acm: fix I/O after failed open

Make sure to kill any already submitted read urbs on read-urb submission
failures in open in order to prevent doing I/O for a closed port.

Fixes: 088c64f81284 ("USB: cdc-acm: re-write read processing")
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 3 insertions, 0 deletions

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 6c6928a154bd..eddeba61a88c 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -506,6 +506,7 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
 {
         struct acm *acm = container_of(port, struct acm, port);
         int retval = -ENODEV;
+        int i;
 
         dev_dbg(&acm->control->dev, "%s\n", __func__);
 
@@ -556,6 +557,8 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
         return 0;
 
 error_submit_read_urbs:
+        for (i = 0; i < acm->rx_buflimit; i++)
+                usb_kill_urb(acm->read_urbs[i]);
         acm->ctrlout = 0;
         acm_set_control(acm, acm->ctrlout);
 error_set_control: