diff options
author | Peter Chen <peter.chen@freescale.com> | 2015-02-10 23:44:44 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-18 11:19:08 -0400 |
commit | a4cf1b14cfbc57a12ea2d997b93735a99f70d810 (patch) | |
tree | 1c1a514500be4b0f290e9c9299575e3eb135f3c3 /drivers/usb/chipidea/ci_hdrc_imx.c | |
parent | 73dea4a912b2bfe955305de4891018f9e71e399d (diff) |
usb: chipidea: imx: simplify the usbmisc callers
Move struct imx_usbmisc_data NULL pointer judgement from caller to
each API, it can simplify the caller.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/chipidea/ci_hdrc_imx.c')
-rw-r--r-- | drivers/usb/chipidea/ci_hdrc_imx.c | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 421651060f8d..353989e5675b 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c | |||
@@ -149,13 +149,10 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) | |||
149 | if (ret) | 149 | if (ret) |
150 | goto err_clk; | 150 | goto err_clk; |
151 | 151 | ||
152 | if (data->usbmisc_data) { | 152 | ret = imx_usbmisc_init(data->usbmisc_data); |
153 | ret = imx_usbmisc_init(data->usbmisc_data); | 153 | if (ret) { |
154 | if (ret) { | 154 | dev_err(&pdev->dev, "usbmisc init failed, ret=%d\n", ret); |
155 | dev_err(&pdev->dev, "usbmisc init failed, ret=%d\n", | 155 | goto err_clk; |
156 | ret); | ||
157 | goto err_clk; | ||
158 | } | ||
159 | } | 156 | } |
160 | 157 | ||
161 | data->ci_pdev = ci_hdrc_add_device(&pdev->dev, | 158 | data->ci_pdev = ci_hdrc_add_device(&pdev->dev, |
@@ -169,13 +166,10 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) | |||
169 | goto err_clk; | 166 | goto err_clk; |
170 | } | 167 | } |
171 | 168 | ||
172 | if (data->usbmisc_data) { | 169 | ret = imx_usbmisc_init_post(data->usbmisc_data); |
173 | ret = imx_usbmisc_init_post(data->usbmisc_data); | 170 | if (ret) { |
174 | if (ret) { | 171 | dev_err(&pdev->dev, "usbmisc post failed, ret=%d\n", ret); |
175 | dev_err(&pdev->dev, "usbmisc post failed, ret=%d\n", | 172 | goto disable_device; |
176 | ret); | ||
177 | goto disable_device; | ||
178 | } | ||
179 | } | 173 | } |
180 | 174 | ||
181 | platform_set_drvdata(pdev, data); | 175 | platform_set_drvdata(pdev, data); |