aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorJon Ringle <jringle@gridpoint.com>2014-07-25 13:53:36 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-07-27 14:50:38 -0400
commitdc824ebed081ed6227772b3cc5f9c7a6683fb489 (patch)
treeae20896a4bde8c38428dc593b684d6a6633dc7c2 /drivers/tty
parentc8ed99d4f6a8ac03f397877d25428698f461a2af (diff)
serial: sc16is7xx: Correct initialization of s->clk
The s->clk never gets setup in sc16is7xx_probe() and instead was using a local clk variable, but then testing the uninitialized s->clk during teardown Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jon Ringle <jringle@gridpoint.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/sc16is7xx.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 914825e03427..3284c31085a7 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1060,7 +1060,6 @@ static int sc16is7xx_probe(struct device *dev,
1060 struct regmap *regmap, int irq, unsigned long flags) 1060 struct regmap *regmap, int irq, unsigned long flags)
1061{ 1061{
1062 unsigned long freq, *pfreq = dev_get_platdata(dev); 1062 unsigned long freq, *pfreq = dev_get_platdata(dev);
1063 struct clk *clk;
1064 int i, ret; 1063 int i, ret;
1065 struct sc16is7xx_port *s; 1064 struct sc16is7xx_port *s;
1066 1065
@@ -1076,14 +1075,14 @@ static int sc16is7xx_probe(struct device *dev,
1076 return -ENOMEM; 1075 return -ENOMEM;
1077 } 1076 }
1078 1077
1079 clk = devm_clk_get(dev, NULL); 1078 s->clk = devm_clk_get(dev, NULL);
1080 if (IS_ERR(clk)) { 1079 if (IS_ERR(s->clk)) {
1081 if (pfreq) 1080 if (pfreq)
1082 freq = *pfreq; 1081 freq = *pfreq;
1083 else 1082 else
1084 return PTR_ERR(clk); 1083 return PTR_ERR(s->clk);
1085 } else { 1084 } else {
1086 freq = clk_get_rate(clk); 1085 freq = clk_get_rate(s->clk);
1087 } 1086 }
1088 1087
1089 s->regmap = regmap; 1088 s->regmap = regmap;