aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-08-27 18:59:53 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-08-27 18:59:53 -0400
commit7b013e440a4ebe05d32ad4ecd657c276f3994558 (patch)
tree9c6a27d7056939c780902cdf682f863584c32926 /drivers/tty
parent8316d04c42b94e94c8e54027d7c77ebe098ab5fa (diff)
Revert "serial: omap: Fix IRQ handling return value"
This reverts commit 908fd7e566b4c12e36e4487d2d5946de5e5ea30f. Kevin writes: Greg, without a better justification in the changelog, I think this patch should be dropped from tty-next. Reported-by: Kevin Hilman <khilman@linaro.org> Cc: Ruchika Kharwar <ruchika@ti.com> Cc: Alexander Savchenko <oleksandr.savchenko@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/omap-serial.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 2fa7b5ce2e0c..b0f46e666e1a 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -538,6 +538,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
538 struct uart_omap_port *up = dev_id; 538 struct uart_omap_port *up = dev_id;
539 unsigned int iir, lsr; 539 unsigned int iir, lsr;
540 unsigned int type; 540 unsigned int type;
541 irqreturn_t ret = IRQ_NONE;
541 int max_count = 256; 542 int max_count = 256;
542 543
543 spin_lock(&up->port.lock); 544 spin_lock(&up->port.lock);
@@ -548,6 +549,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
548 if (iir & UART_IIR_NO_INT) 549 if (iir & UART_IIR_NO_INT)
549 break; 550 break;
550 551
552 ret = IRQ_HANDLED;
551 lsr = serial_in(up, UART_LSR); 553 lsr = serial_in(up, UART_LSR);
552 554
553 /* extract IRQ type from IIR register */ 555 /* extract IRQ type from IIR register */
@@ -586,7 +588,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
586 pm_runtime_put_autosuspend(up->dev); 588 pm_runtime_put_autosuspend(up->dev);
587 up->port_activity = jiffies; 589 up->port_activity = jiffies;
588 590
589 return IRQ_HANDLED; 591 return ret;
590} 592}
591 593
592static unsigned int serial_omap_tx_empty(struct uart_port *port) 594static unsigned int serial_omap_tx_empty(struct uart_port *port)