diff options
author | Tejun Heo <tj@kernel.org> | 2012-08-20 17:51:24 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2012-08-20 17:51:24 -0400 |
commit | 43829731dd372d04d6706c51052b9dabab9ca356 (patch) | |
tree | 2cfa255dcec2f5cc867ab39cdcf4a25eae54845f /drivers/tty | |
parent | ae930e0f4e66fd540c6fbad9f1e2a7743d8b9afe (diff) |
workqueue: deprecate flush[_delayed]_work_sync()
flush[_delayed]_work_sync() are now spurious. Mark them deprecated
and convert all users to flush[_delayed]_work().
If you're cc'd and wondering what's going on: Now all workqueues are
non-reentrant and the regular flushes guarantee that the work item is
not pending or running on any CPU on return, so there's no reason to
use the sync flushes at all and they're going away.
This patch doesn't make any functional difference.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Mattia Dongili <malattia@linux.it>
Cc: Kent Yoder <key@linux.vnet.ibm.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: Bryan Wu <bryan.wu@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org
Cc: Anton Vorontsov <cbou@mail.ru>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Petr Vandrovec <petr@vandrovec.name>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'drivers/tty')
-rw-r--r-- | drivers/tty/hvc/hvsi.c | 2 | ||||
-rw-r--r-- | drivers/tty/ipwireless/hardware.c | 2 | ||||
-rw-r--r-- | drivers/tty/ipwireless/network.c | 4 | ||||
-rw-r--r-- | drivers/tty/serial/kgdboc.c | 2 | ||||
-rw-r--r-- | drivers/tty/serial/omap-serial.c | 2 | ||||
-rw-r--r-- | drivers/tty/tty_ldisc.c | 6 |
6 files changed, 9 insertions, 9 deletions
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c index 6f5bc49c441f..1f8e8b37ed23 100644 --- a/drivers/tty/hvc/hvsi.c +++ b/drivers/tty/hvc/hvsi.c | |||
@@ -765,7 +765,7 @@ static void hvsi_flush_output(struct hvsi_struct *hp) | |||
765 | 765 | ||
766 | /* 'writer' could still be pending if it didn't see n_outbuf = 0 yet */ | 766 | /* 'writer' could still be pending if it didn't see n_outbuf = 0 yet */ |
767 | cancel_delayed_work_sync(&hp->writer); | 767 | cancel_delayed_work_sync(&hp->writer); |
768 | flush_work_sync(&hp->handshaker); | 768 | flush_work(&hp->handshaker); |
769 | 769 | ||
770 | /* | 770 | /* |
771 | * it's also possible that our timeout expired and hvsi_write_worker | 771 | * it's also possible that our timeout expired and hvsi_write_worker |
diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c index 0aeb5a38d296..b4ba0670dc54 100644 --- a/drivers/tty/ipwireless/hardware.c +++ b/drivers/tty/ipwireless/hardware.c | |||
@@ -1729,7 +1729,7 @@ void ipwireless_hardware_free(struct ipw_hardware *hw) | |||
1729 | 1729 | ||
1730 | ipwireless_stop_interrupts(hw); | 1730 | ipwireless_stop_interrupts(hw); |
1731 | 1731 | ||
1732 | flush_work_sync(&hw->work_rx); | 1732 | flush_work(&hw->work_rx); |
1733 | 1733 | ||
1734 | for (i = 0; i < NL_NUM_OF_ADDRESSES; i++) | 1734 | for (i = 0; i < NL_NUM_OF_ADDRESSES; i++) |
1735 | if (hw->packet_assembler[i] != NULL) | 1735 | if (hw->packet_assembler[i] != NULL) |
diff --git a/drivers/tty/ipwireless/network.c b/drivers/tty/ipwireless/network.c index 57c8b481113f..90ea902ff191 100644 --- a/drivers/tty/ipwireless/network.c +++ b/drivers/tty/ipwireless/network.c | |||
@@ -430,8 +430,8 @@ void ipwireless_network_free(struct ipw_network *network) | |||
430 | network->shutting_down = 1; | 430 | network->shutting_down = 1; |
431 | 431 | ||
432 | ipwireless_ppp_close(network); | 432 | ipwireless_ppp_close(network); |
433 | flush_work_sync(&network->work_go_online); | 433 | flush_work(&network->work_go_online); |
434 | flush_work_sync(&network->work_go_offline); | 434 | flush_work(&network->work_go_offline); |
435 | 435 | ||
436 | ipwireless_stop_interrupts(network->hardware); | 436 | ipwireless_stop_interrupts(network->hardware); |
437 | ipwireless_associate_network(network->hardware, NULL); | 437 | ipwireless_associate_network(network->hardware, NULL); |
diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 2b42a01a81c6..ebabf929f460 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c | |||
@@ -122,7 +122,7 @@ static void kgdboc_unregister_kbd(void) | |||
122 | i--; | 122 | i--; |
123 | } | 123 | } |
124 | } | 124 | } |
125 | flush_work_sync(&kgdboc_restore_input_work); | 125 | flush_work(&kgdboc_restore_input_work); |
126 | } | 126 | } |
127 | #else /* ! CONFIG_KDB_KEYBOARD */ | 127 | #else /* ! CONFIG_KDB_KEYBOARD */ |
128 | #define kgdboc_register_kbd(x) 0 | 128 | #define kgdboc_register_kbd(x) 0 |
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index d3cda0cb2df0..0952d71bdf28 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c | |||
@@ -1205,7 +1205,7 @@ static int serial_omap_suspend(struct device *dev) | |||
1205 | 1205 | ||
1206 | if (up) { | 1206 | if (up) { |
1207 | uart_suspend_port(&serial_omap_reg, &up->port); | 1207 | uart_suspend_port(&serial_omap_reg, &up->port); |
1208 | flush_work_sync(&up->qos_work); | 1208 | flush_work(&up->qos_work); |
1209 | } | 1209 | } |
1210 | 1210 | ||
1211 | return 0; | 1211 | return 0; |
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 6f99c9959f0c..ac5be812dbe3 100644 --- a/drivers/tty/tty_ldisc.c +++ b/drivers/tty/tty_ldisc.c | |||
@@ -523,9 +523,9 @@ static int tty_ldisc_halt(struct tty_struct *tty) | |||
523 | */ | 523 | */ |
524 | static void tty_ldisc_flush_works(struct tty_struct *tty) | 524 | static void tty_ldisc_flush_works(struct tty_struct *tty) |
525 | { | 525 | { |
526 | flush_work_sync(&tty->hangup_work); | 526 | flush_work(&tty->hangup_work); |
527 | flush_work_sync(&tty->SAK_work); | 527 | flush_work(&tty->SAK_work); |
528 | flush_work_sync(&tty->buf.work); | 528 | flush_work(&tty->buf.work); |
529 | } | 529 | } |
530 | 530 | ||
531 | /** | 531 | /** |