diff options
author | Alan Cox <alan@linux.intel.com> | 2011-02-14 11:26:14 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-02-17 14:47:33 -0500 |
commit | 60b33c133ca0b7c0b6072c87234b63fee6e80558 (patch) | |
tree | 379340a7ab563df42ddb2907be6f282202244077 /drivers/tty/tty_io.c | |
parent | adf9251fe9b87b5a50deebe489db2df8df4715fc (diff) |
tiocmget: kill off the passing of the struct file
We don't actually need this and it causes problems for internal use of
this functionality. Currently there is a single use of the FILE * pointer.
That is the serial core which uses it to check tty_hung_up_p. However if
that is true then IO_ERROR is also already set so the check may be removed.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/tty/tty_io.c')
-rw-r--r-- | drivers/tty/tty_io.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 0065da4b11c1..fde5a4dae3dd 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c | |||
@@ -2465,12 +2465,12 @@ out: | |||
2465 | * Locking: none (up to the driver) | 2465 | * Locking: none (up to the driver) |
2466 | */ | 2466 | */ |
2467 | 2467 | ||
2468 | static int tty_tiocmget(struct tty_struct *tty, struct file *file, int __user *p) | 2468 | static int tty_tiocmget(struct tty_struct *tty, int __user *p) |
2469 | { | 2469 | { |
2470 | int retval = -EINVAL; | 2470 | int retval = -EINVAL; |
2471 | 2471 | ||
2472 | if (tty->ops->tiocmget) { | 2472 | if (tty->ops->tiocmget) { |
2473 | retval = tty->ops->tiocmget(tty, file); | 2473 | retval = tty->ops->tiocmget(tty); |
2474 | 2474 | ||
2475 | if (retval >= 0) | 2475 | if (retval >= 0) |
2476 | retval = put_user(retval, p); | 2476 | retval = put_user(retval, p); |
@@ -2655,7 +2655,7 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
2655 | return send_break(tty, arg ? arg*100 : 250); | 2655 | return send_break(tty, arg ? arg*100 : 250); |
2656 | 2656 | ||
2657 | case TIOCMGET: | 2657 | case TIOCMGET: |
2658 | return tty_tiocmget(tty, file, p); | 2658 | return tty_tiocmget(tty, p); |
2659 | case TIOCMSET: | 2659 | case TIOCMSET: |
2660 | case TIOCMBIC: | 2660 | case TIOCMBIC: |
2661 | case TIOCMBIS: | 2661 | case TIOCMBIS: |