aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/tty/serial
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-03-11 13:10:46 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-03-17 19:20:49 -0400
commit9b971cd206c019fc6aeeb7e04136a49f9312df4a (patch)
tree0e15d7f7dbad6a7e6351c4020569c52cae3b2b09 /drivers/tty/serial
parentd3dfe5d9b4c8b3156b28f99f7a4a59ad8be09b15 (diff)
serial: sh-sci: Neaten dev_<level> uses
Add missing newlines and coalesce formats. Realign arguments. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Simon Horman <horms+renesas@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial')
-rw-r--r--drivers/tty/serial/sh-sci.c38
1 files changed, 18 insertions, 20 deletions
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 634ecae2efd4..7ee5a79222ff 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -788,7 +788,7 @@ static int sci_handle_errors(struct uart_port *port)
788 if (tty_insert_flip_char(tport, 0, TTY_OVERRUN)) 788 if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))
789 copied++; 789 copied++;
790 790
791 dev_notice(port->dev, "overrun error"); 791 dev_notice(port->dev, "overrun error\n");
792 } 792 }
793 793
794 if (status & SCxSR_FER(port)) { 794 if (status & SCxSR_FER(port)) {
@@ -830,7 +830,7 @@ static int sci_handle_errors(struct uart_port *port)
830 if (tty_insert_flip_char(tport, 0, TTY_PARITY)) 830 if (tty_insert_flip_char(tport, 0, TTY_PARITY))
831 copied++; 831 copied++;
832 832
833 dev_notice(port->dev, "parity error"); 833 dev_notice(port->dev, "parity error\n");
834 } 834 }
835 835
836 if (copied) 836 if (copied)
@@ -1292,7 +1292,8 @@ static void sci_dma_rx_complete(void *arg)
1292 unsigned long flags; 1292 unsigned long flags;
1293 int count; 1293 int count;
1294 1294
1295 dev_dbg(port->dev, "%s(%d) active #%d\n", __func__, port->line, s->active_rx); 1295 dev_dbg(port->dev, "%s(%d) active #%d\n",
1296 __func__, port->line, s->active_rx);
1296 1297
1297 spin_lock_irqsave(&port->lock, flags); 1298 spin_lock_irqsave(&port->lock, flags);
1298 1299
@@ -1368,8 +1369,8 @@ static void sci_submit_rx(struct sci_port *s)
1368 sci_rx_dma_release(s, true); 1369 sci_rx_dma_release(s, true);
1369 return; 1370 return;
1370 } 1371 }
1371 dev_dbg(s->port.dev, "%s(): cookie %d to #%d\n", __func__, 1372 dev_dbg(s->port.dev, "%s(): cookie %d to #%d\n",
1372 s->cookie_rx[i], i); 1373 __func__, s->cookie_rx[i], i);
1373 } 1374 }
1374 1375
1375 s->active_rx = s->cookie_rx[0]; 1376 s->active_rx = s->cookie_rx[0];
@@ -1428,8 +1429,8 @@ static void work_fn_rx(struct work_struct *work)
1428 1429
1429 s->active_rx = s->cookie_rx[!new]; 1430 s->active_rx = s->cookie_rx[!new];
1430 1431
1431 dev_dbg(port->dev, "%s: cookie %d #%d, new active #%d\n", __func__, 1432 dev_dbg(port->dev, "%s: cookie %d #%d, new active #%d\n",
1432 s->cookie_rx[new], new, s->active_rx); 1433 __func__, s->cookie_rx[new], new, s->active_rx);
1433} 1434}
1434 1435
1435static void work_fn_tx(struct work_struct *work) 1436static void work_fn_tx(struct work_struct *work)
@@ -1482,8 +1483,8 @@ static void work_fn_tx(struct work_struct *work)
1482 return; 1483 return;
1483 } 1484 }
1484 1485
1485 dev_dbg(port->dev, "%s: %p: %d...%d, cookie %d\n", __func__, 1486 dev_dbg(port->dev, "%s: %p: %d...%d, cookie %d\n",
1486 xmit->buf, xmit->tail, xmit->head, s->cookie_tx); 1487 __func__, xmit->buf, xmit->tail, xmit->head, s->cookie_tx);
1487 1488
1488 dma_async_issue_pending(chan); 1489 dma_async_issue_pending(chan);
1489} 1490}
@@ -1602,8 +1603,8 @@ static bool filter(struct dma_chan *chan, void *slave)
1602{ 1603{
1603 struct sh_dmae_slave *param = slave; 1604 struct sh_dmae_slave *param = slave;
1604 1605
1605 dev_dbg(chan->device->dev, "%s: slave ID %d\n", __func__, 1606 dev_dbg(chan->device->dev, "%s: slave ID %d\n",
1606 param->shdma_slave.slave_id); 1607 __func__, param->shdma_slave.slave_id);
1607 1608
1608 chan->private = &param->shdma_slave; 1609 chan->private = &param->shdma_slave;
1609 return true; 1610 return true;
@@ -1632,8 +1633,7 @@ static void sci_request_dma(struct uart_port *port)
1632 dma_cap_mask_t mask; 1633 dma_cap_mask_t mask;
1633 int nent; 1634 int nent;
1634 1635
1635 dev_dbg(port->dev, "%s: port %d\n", __func__, 1636 dev_dbg(port->dev, "%s: port %d\n", __func__, port->line);
1636 port->line);
1637 1637
1638 if (s->cfg->dma_slave_tx <= 0 || s->cfg->dma_slave_rx <= 0) 1638 if (s->cfg->dma_slave_tx <= 0 || s->cfg->dma_slave_rx <= 0)
1639 return; 1639 return;
@@ -1661,7 +1661,8 @@ static void sci_request_dma(struct uart_port *port)
1661 if (!nent) 1661 if (!nent)
1662 sci_tx_dma_release(s, false); 1662 sci_tx_dma_release(s, false);
1663 else 1663 else
1664 dev_dbg(port->dev, "%s: mapped %d@%p to %pad\n", __func__, 1664 dev_dbg(port->dev, "%s: mapped %d@%p to %pad\n",
1665 __func__,
1665 sg_dma_len(&s->sg_tx), port->state->xmit.buf, 1666 sg_dma_len(&s->sg_tx), port->state->xmit.buf,
1666 &sg_dma_address(&s->sg_tx)); 1667 &sg_dma_address(&s->sg_tx));
1667 1668
@@ -1935,8 +1936,7 @@ static void sci_set_termios(struct uart_port *port, struct ktermios *termios,
1935 if (s->chan_rx) { 1936 if (s->chan_rx) {
1936 s->rx_timeout = (port->timeout - HZ / 50) * s->buf_len_rx * 3 / 1937 s->rx_timeout = (port->timeout - HZ / 50) * s->buf_len_rx * 3 /
1937 port->fifosize / 2; 1938 port->fifosize / 2;
1938 dev_dbg(port->dev, 1939 dev_dbg(port->dev, "DMA Rx t-out %ums, tty t-out %u jiffies\n",
1939 "DMA Rx t-out %ums, tty t-out %u jiffies\n",
1940 s->rx_timeout * 1000 / HZ, port->timeout); 1940 s->rx_timeout * 1000 / HZ, port->timeout);
1941 if (s->rx_timeout < msecs_to_jiffies(20)) 1941 if (s->rx_timeout < msecs_to_jiffies(20))
1942 s->rx_timeout = msecs_to_jiffies(20); 1942 s->rx_timeout = msecs_to_jiffies(20);
@@ -2503,11 +2503,9 @@ static int sci_probe_single(struct platform_device *dev,
2503 2503
2504 /* Sanity check */ 2504 /* Sanity check */
2505 if (unlikely(index >= SCI_NPORTS)) { 2505 if (unlikely(index >= SCI_NPORTS)) {
2506 dev_notice(&dev->dev, "Attempting to register port " 2506 dev_notice(&dev->dev, "Attempting to register port %d when only %d are available\n",
2507 "%d when only %d are available.\n",
2508 index+1, SCI_NPORTS); 2507 index+1, SCI_NPORTS);
2509 dev_notice(&dev->dev, "Consider bumping " 2508 dev_notice(&dev->dev, "Consider bumping CONFIG_SERIAL_SH_SCI_NR_UARTS!\n");
2510 "CONFIG_SERIAL_SH_SCI_NR_UARTS!\n");
2511 return -EINVAL; 2509 return -EINVAL;
2512 } 2510 }
2513 2511