diff options
author | Alan Cox <alan@linux.intel.com> | 2011-02-14 11:26:50 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-02-17 14:52:43 -0500 |
commit | 20b9d17715017ae4dd4ec87fabc36d33b9de708e (patch) | |
tree | 64e9c4ff845844298f9056357d9f4914802207f8 /drivers/tty/serial | |
parent | 60b33c133ca0b7c0b6072c87234b63fee6e80558 (diff) |
tiocmset: kill the file pointer argument
Doing tiocmget was such fun we should do tiocmset as well for the same
reasons
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/tty/serial')
-rw-r--r-- | drivers/tty/serial/68360serial.c | 2 | ||||
-rw-r--r-- | drivers/tty/serial/crisv10.c | 3 | ||||
-rw-r--r-- | drivers/tty/serial/ifx6x60.c | 3 | ||||
-rw-r--r-- | drivers/tty/serial/serial_core.c | 6 |
4 files changed, 5 insertions, 9 deletions
diff --git a/drivers/tty/serial/68360serial.c b/drivers/tty/serial/68360serial.c index 2a52cf14ce50..217fe1c299e0 100644 --- a/drivers/tty/serial/68360serial.c +++ b/drivers/tty/serial/68360serial.c | |||
@@ -1271,7 +1271,7 @@ static int rs_360_tiocmget(struct tty_struct *tty) | |||
1271 | return result; | 1271 | return result; |
1272 | } | 1272 | } |
1273 | 1273 | ||
1274 | static int rs_360_tiocmset(struct tty_struct *tty, struct file *file, | 1274 | static int rs_360_tiocmset(struct tty_struct *tty, |
1275 | unsigned int set, unsigned int clear) | 1275 | unsigned int set, unsigned int clear) |
1276 | { | 1276 | { |
1277 | #ifdef modem_control | 1277 | #ifdef modem_control |
diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c index 8cc5c0224b25..b9fcd0bda60c 100644 --- a/drivers/tty/serial/crisv10.c +++ b/drivers/tty/serial/crisv10.c | |||
@@ -3581,8 +3581,7 @@ rs_break(struct tty_struct *tty, int break_state) | |||
3581 | } | 3581 | } |
3582 | 3582 | ||
3583 | static int | 3583 | static int |
3584 | rs_tiocmset(struct tty_struct *tty, struct file *file, | 3584 | rs_tiocmset(struct tty_struct *tty, unsigned int set, unsigned int clear) |
3585 | unsigned int set, unsigned int clear) | ||
3586 | { | 3585 | { |
3587 | struct e100_serial *info = (struct e100_serial *)tty->driver_data; | 3586 | struct e100_serial *info = (struct e100_serial *)tty->driver_data; |
3588 | unsigned long flags; | 3587 | unsigned long flags; |
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c index 4d26d39ec344..8ee5a41d340d 100644 --- a/drivers/tty/serial/ifx6x60.c +++ b/drivers/tty/serial/ifx6x60.c | |||
@@ -263,7 +263,6 @@ static int ifx_spi_tiocmget(struct tty_struct *tty) | |||
263 | /** | 263 | /** |
264 | * ifx_spi_tiocmset - set modem bits | 264 | * ifx_spi_tiocmset - set modem bits |
265 | * @tty: the tty structure | 265 | * @tty: the tty structure |
266 | * @filp: file handle issuing the request | ||
267 | * @set: bits to set | 266 | * @set: bits to set |
268 | * @clear: bits to clear | 267 | * @clear: bits to clear |
269 | * | 268 | * |
@@ -272,7 +271,7 @@ static int ifx_spi_tiocmget(struct tty_struct *tty) | |||
272 | * | 271 | * |
273 | * FIXME: do we need to kick the tranfers when we do this ? | 272 | * FIXME: do we need to kick the tranfers when we do this ? |
274 | */ | 273 | */ |
275 | static int ifx_spi_tiocmset(struct tty_struct *tty, struct file *filp, | 274 | static int ifx_spi_tiocmset(struct tty_struct *tty, |
276 | unsigned int set, unsigned int clear) | 275 | unsigned int set, unsigned int clear) |
277 | { | 276 | { |
278 | struct ifx_spi_device *ifx_dev = tty->driver_data; | 277 | struct ifx_spi_device *ifx_dev = tty->driver_data; |
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 53e490e47560..623d6bd911d7 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c | |||
@@ -925,8 +925,7 @@ static int uart_tiocmget(struct tty_struct *tty) | |||
925 | } | 925 | } |
926 | 926 | ||
927 | static int | 927 | static int |
928 | uart_tiocmset(struct tty_struct *tty, struct file *file, | 928 | uart_tiocmset(struct tty_struct *tty, unsigned int set, unsigned int clear) |
929 | unsigned int set, unsigned int clear) | ||
930 | { | 929 | { |
931 | struct uart_state *state = tty->driver_data; | 930 | struct uart_state *state = tty->driver_data; |
932 | struct uart_port *uport = state->uart_port; | 931 | struct uart_port *uport = state->uart_port; |
@@ -934,8 +933,7 @@ uart_tiocmset(struct tty_struct *tty, struct file *file, | |||
934 | int ret = -EIO; | 933 | int ret = -EIO; |
935 | 934 | ||
936 | mutex_lock(&port->mutex); | 935 | mutex_lock(&port->mutex); |
937 | if ((!file || !tty_hung_up_p(file)) && | 936 | if (!(tty->flags & (1 << TTY_IO_ERROR))) { |
938 | !(tty->flags & (1 << TTY_IO_ERROR))) { | ||
939 | uart_update_mctrl(uport, set, clear); | 937 | uart_update_mctrl(uport, set, clear); |
940 | ret = 0; | 938 | ret = 0; |
941 | } | 939 | } |