aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/thermal
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2014-11-13 10:01:03 -0500
committerEduardo Valentin <edubezval@gmail.com>2014-11-20 09:52:51 -0500
commit9e288d6430373a679d1ee88ff90813cd6be20dd2 (patch)
tree4fb722d9c518a75391fdf67740168f46f0d200e7 /drivers/thermal
parent77a37a92ca18e4385bfcca9f2762d39fe83110b9 (diff)
thermal: exynos: remove needless emul_temp_shift abstraction
reg->emul_temp_shift is used only in exynos_tmu_set_emulation() and accessed only if TMU_SUPPORT_EMULATION flag is set. This flag is not set for Exynos4210 (reg->emul_temp_shift field is not even assigned in exynos4210_tmu_registers and is assigned to identical value for all other SoC types) so the abstraction is not needed and can be removed. There should be no functional changes caused by this patch. Cc: Amit Daniel Kachhap <amit.daniel@samsung.com> Cc: Lukasz Majewski <l.majewski@samsung.com> Cc: Eduardo Valentin <edubezval@gmail.com> Cc: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Tested-by: Lukasz Majewski <l.majewski@samsung.com> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/thermal')
-rw-r--r--drivers/thermal/samsung/exynos_tmu.c4
-rw-r--r--drivers/thermal/samsung/exynos_tmu.h2
-rw-r--r--drivers/thermal/samsung/exynos_tmu_data.c5
3 files changed, 2 insertions, 9 deletions
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 3f3b8cf0455a..c108a1f3de71 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -383,8 +383,8 @@ static int exynos_tmu_set_emulation(void *drv_data, unsigned long temp)
383 val &= ~(EXYNOS_EMUL_TIME_MASK << reg->emul_time_shift); 383 val &= ~(EXYNOS_EMUL_TIME_MASK << reg->emul_time_shift);
384 val |= (EXYNOS_EMUL_TIME << reg->emul_time_shift); 384 val |= (EXYNOS_EMUL_TIME << reg->emul_time_shift);
385 } 385 }
386 val &= ~(EXYNOS_EMUL_DATA_MASK << reg->emul_temp_shift); 386 val &= ~(EXYNOS_EMUL_DATA_MASK << EXYNOS_EMUL_DATA_SHIFT);
387 val |= (temp_to_code(data, temp) << reg->emul_temp_shift) | 387 val |= (temp_to_code(data, temp) << EXYNOS_EMUL_DATA_SHIFT) |
388 EXYNOS_EMUL_ENABLE; 388 EXYNOS_EMUL_ENABLE;
389 } else { 389 } else {
390 val &= ~EXYNOS_EMUL_ENABLE; 390 val &= ~EXYNOS_EMUL_ENABLE;
diff --git a/drivers/thermal/samsung/exynos_tmu.h b/drivers/thermal/samsung/exynos_tmu.h
index 4798313ca5e1..ed3d816ae24c 100644
--- a/drivers/thermal/samsung/exynos_tmu.h
+++ b/drivers/thermal/samsung/exynos_tmu.h
@@ -92,7 +92,6 @@ enum soc_type {
92 * @tmu_intstat: Register containing the interrupt status values. 92 * @tmu_intstat: Register containing the interrupt status values.
93 * @tmu_intclear: Register for clearing the raised interrupt status. 93 * @tmu_intclear: Register for clearing the raised interrupt status.
94 * @emul_con: TMU emulation controller register. 94 * @emul_con: TMU emulation controller register.
95 * @emul_temp_shift: shift bits of emulation temperature.
96 * @emul_time_shift: shift bits of emulation time. 95 * @emul_time_shift: shift bits of emulation time.
97 * @tmu_irqstatus: register to find which TMU generated interrupts. 96 * @tmu_irqstatus: register to find which TMU generated interrupts.
98 * @tmu_pmin: register to get/set the Pmin value. 97 * @tmu_pmin: register to get/set the Pmin value.
@@ -119,7 +118,6 @@ struct exynos_tmu_registers {
119 u32 tmu_intclear; 118 u32 tmu_intclear;
120 119
121 u32 emul_con; 120 u32 emul_con;
122 u32 emul_temp_shift;
123 u32 emul_time_shift; 121 u32 emul_time_shift;
124 122
125 u32 tmu_irqstatus; 123 u32 tmu_irqstatus;
diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
index a120a8cd80ad..c35a6eadafd1 100644
--- a/drivers/thermal/samsung/exynos_tmu_data.c
+++ b/drivers/thermal/samsung/exynos_tmu_data.c
@@ -94,7 +94,6 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = {
94 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT, 94 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT,
95 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR, 95 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR,
96 .emul_con = EXYNOS_EMUL_CON, 96 .emul_con = EXYNOS_EMUL_CON,
97 .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
98 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT, 97 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT,
99}; 98};
100 99
@@ -167,7 +166,6 @@ static const struct exynos_tmu_registers exynos4412_tmu_registers = {
167 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT, 166 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT,
168 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR, 167 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR,
169 .emul_con = EXYNOS_EMUL_CON, 168 .emul_con = EXYNOS_EMUL_CON,
170 .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
171 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT, 169 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT,
172}; 170};
173 171
@@ -252,7 +250,6 @@ static const struct exynos_tmu_registers exynos5260_tmu_registers = {
252 .tmu_intstat = EXYNOS5260_TMU_REG_INTSTAT, 250 .tmu_intstat = EXYNOS5260_TMU_REG_INTSTAT,
253 .tmu_intclear = EXYNOS5260_TMU_REG_INTCLEAR, 251 .tmu_intclear = EXYNOS5260_TMU_REG_INTCLEAR,
254 .emul_con = EXYNOS5260_EMUL_CON, 252 .emul_con = EXYNOS5260_EMUL_CON,
255 .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
256 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT, 253 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT,
257}; 254};
258 255
@@ -327,7 +324,6 @@ static const struct exynos_tmu_registers exynos5420_tmu_registers = {
327 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT, 324 .tmu_intstat = EXYNOS_TMU_REG_INTSTAT,
328 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR, 325 .tmu_intclear = EXYNOS_TMU_REG_INTCLEAR,
329 .emul_con = EXYNOS_EMUL_CON, 326 .emul_con = EXYNOS_EMUL_CON,
330 .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
331 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT, 327 .emul_time_shift = EXYNOS_EMUL_TIME_SHIFT,
332}; 328};
333 329
@@ -411,7 +407,6 @@ static const struct exynos_tmu_registers exynos5440_tmu_registers = {
411 .tmu_intclear = EXYNOS5440_TMU_S0_7_IRQ, 407 .tmu_intclear = EXYNOS5440_TMU_S0_7_IRQ,
412 .tmu_irqstatus = EXYNOS5440_TMU_IRQ_STATUS, 408 .tmu_irqstatus = EXYNOS5440_TMU_IRQ_STATUS,
413 .emul_con = EXYNOS5440_TMU_S0_7_DEBUG, 409 .emul_con = EXYNOS5440_TMU_S0_7_DEBUG,
414 .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
415 .tmu_pmin = EXYNOS5440_TMU_PMIN, 410 .tmu_pmin = EXYNOS5440_TMU_PMIN,
416}; 411};
417 412