diff options
author | Andy Grover <agrover@redhat.com> | 2012-07-12 20:34:54 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-07-16 20:35:22 -0400 |
commit | ee1b1b9c3db29643eb82a6b52694555c91af2f97 (patch) | |
tree | 3329b526e53a31de1651437fbac6d77115e2a748 /drivers/target | |
parent | af8772926f019b7bddd7477b8de5f3b0f12bad21 (diff) |
target: Remove unneeded double parentheses
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r-- | drivers/target/iscsi/iscsi_target.c | 2 | ||||
-rw-r--r-- | drivers/target/iscsi/iscsi_target_login.c | 6 | ||||
-rw-r--r-- | drivers/target/iscsi/iscsi_target_tpg.c | 2 | ||||
-rw-r--r-- | drivers/target/target_core_pr.c | 6 |
4 files changed, 8 insertions, 8 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 0aa04a0b91de..5d56ce44a6c5 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c | |||
@@ -2685,7 +2685,7 @@ static int iscsit_send_logout_response( | |||
2685 | */ | 2685 | */ |
2686 | logout_conn = iscsit_get_conn_from_cid_rcfr(sess, | 2686 | logout_conn = iscsit_get_conn_from_cid_rcfr(sess, |
2687 | cmd->logout_cid); | 2687 | cmd->logout_cid); |
2688 | if ((logout_conn)) { | 2688 | if (logout_conn) { |
2689 | iscsit_connection_reinstatement_rcfr(logout_conn); | 2689 | iscsit_connection_reinstatement_rcfr(logout_conn); |
2690 | iscsit_dec_conn_usage_count(logout_conn); | 2690 | iscsit_dec_conn_usage_count(logout_conn); |
2691 | } | 2691 | } |
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c index a3656c9903a1..1434110b052c 100644 --- a/drivers/target/iscsi/iscsi_target_login.c +++ b/drivers/target/iscsi/iscsi_target_login.c | |||
@@ -518,7 +518,7 @@ int iscsi_login_post_auth_non_zero_tsih( | |||
518 | * initiator and release the new connection. | 518 | * initiator and release the new connection. |
519 | */ | 519 | */ |
520 | conn_ptr = iscsit_get_conn_from_cid_rcfr(sess, cid); | 520 | conn_ptr = iscsit_get_conn_from_cid_rcfr(sess, cid); |
521 | if ((conn_ptr)) { | 521 | if (conn_ptr) { |
522 | pr_err("Connection exists with CID %hu for %s," | 522 | pr_err("Connection exists with CID %hu for %s," |
523 | " performing connection reinstatement.\n", | 523 | " performing connection reinstatement.\n", |
524 | conn_ptr->cid, sess->sess_ops->InitiatorName); | 524 | conn_ptr->cid, sess->sess_ops->InitiatorName); |
@@ -539,7 +539,7 @@ int iscsi_login_post_auth_non_zero_tsih( | |||
539 | if (sess->sess_ops->ErrorRecoveryLevel == 2) { | 539 | if (sess->sess_ops->ErrorRecoveryLevel == 2) { |
540 | cr = iscsit_get_inactive_connection_recovery_entry( | 540 | cr = iscsit_get_inactive_connection_recovery_entry( |
541 | sess, cid); | 541 | sess, cid); |
542 | if ((cr)) { | 542 | if (cr) { |
543 | pr_debug("Performing implicit logout" | 543 | pr_debug("Performing implicit logout" |
544 | " for connection recovery on CID: %hu\n", | 544 | " for connection recovery on CID: %hu\n", |
545 | conn->cid); | 545 | conn->cid); |
@@ -1081,7 +1081,7 @@ static int __iscsi_target_login_thread(struct iscsi_np *np) | |||
1081 | goto new_sess_out; | 1081 | goto new_sess_out; |
1082 | 1082 | ||
1083 | zero_tsih = (pdu->tsih == 0x0000); | 1083 | zero_tsih = (pdu->tsih == 0x0000); |
1084 | if ((zero_tsih)) { | 1084 | if (zero_tsih) { |
1085 | /* | 1085 | /* |
1086 | * This is the leading connection of a new session. | 1086 | * This is the leading connection of a new session. |
1087 | * We wait until after authentication to check for | 1087 | * We wait until after authentication to check for |
diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c index 879d8d0fa3fe..142989598aea 100644 --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c | |||
@@ -593,7 +593,7 @@ int iscsit_ta_authentication(struct iscsi_portal_group *tpg, u32 authentication) | |||
593 | } else { | 593 | } else { |
594 | snprintf(buf1, sizeof(buf1), "%s", param->value); | 594 | snprintf(buf1, sizeof(buf1), "%s", param->value); |
595 | none = strstr(buf1, NONE); | 595 | none = strstr(buf1, NONE); |
596 | if ((none)) | 596 | if (none) |
597 | goto out; | 597 | goto out; |
598 | strncat(buf1, ",", strlen(",")); | 598 | strncat(buf1, ",", strlen(",")); |
599 | strncat(buf1, NONE, strlen(NONE)); | 599 | strncat(buf1, NONE, strlen(NONE)); |
diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index a1bcd927a9e6..1e946502c378 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c | |||
@@ -507,7 +507,7 @@ static int core_scsi3_pr_seq_non_holder( | |||
507 | * Check if write exclusive initiator ports *NOT* holding the | 507 | * Check if write exclusive initiator ports *NOT* holding the |
508 | * WRITE_EXCLUSIVE_* reservation. | 508 | * WRITE_EXCLUSIVE_* reservation. |
509 | */ | 509 | */ |
510 | if ((we) && !(registered_nexus)) { | 510 | if (we && !registered_nexus) { |
511 | if (cmd->data_direction == DMA_TO_DEVICE) { | 511 | if (cmd->data_direction == DMA_TO_DEVICE) { |
512 | /* | 512 | /* |
513 | * Conflict for write exclusive | 513 | * Conflict for write exclusive |
@@ -2486,7 +2486,7 @@ static int core_scsi3_pro_reserve( | |||
2486 | */ | 2486 | */ |
2487 | spin_lock(&dev->dev_reservation_lock); | 2487 | spin_lock(&dev->dev_reservation_lock); |
2488 | pr_res_holder = dev->dev_pr_res_holder; | 2488 | pr_res_holder = dev->dev_pr_res_holder; |
2489 | if ((pr_res_holder)) { | 2489 | if (pr_res_holder) { |
2490 | /* | 2490 | /* |
2491 | * From spc4r17 Section 5.7.9: Reserving: | 2491 | * From spc4r17 Section 5.7.9: Reserving: |
2492 | * | 2492 | * |
@@ -4030,7 +4030,7 @@ static int core_scsi3_pri_read_reservation(struct se_cmd *cmd) | |||
4030 | 4030 | ||
4031 | spin_lock(&se_dev->dev_reservation_lock); | 4031 | spin_lock(&se_dev->dev_reservation_lock); |
4032 | pr_reg = se_dev->dev_pr_res_holder; | 4032 | pr_reg = se_dev->dev_pr_res_holder; |
4033 | if ((pr_reg)) { | 4033 | if (pr_reg) { |
4034 | /* | 4034 | /* |
4035 | * Set the hardcoded Additional Length | 4035 | * Set the hardcoded Additional Length |
4036 | */ | 4036 | */ |