diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-11-02 11:48:15 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-11-02 11:58:47 -0400 |
commit | ed327ed337a6ee6919ee092c82ac3edeb63bd4de (patch) | |
tree | cb9db4d1386aae18a115e2d5de330ecb02d18316 /drivers/target | |
parent | 3151d069e9e77043b0e791719bc65896cf24d9f0 (diff) |
target/pscsi: blk_make_request() returns an ERR_PTR()
The check is wrong here because blk_make_request() returns an
ERR_PTR() and it doesn't return NULL.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r-- | drivers/target/target_core_pscsi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index dad671dee9e9..f941b6232614 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c | |||
@@ -1091,7 +1091,7 @@ static int pscsi_do_task(struct se_task *task) | |||
1091 | 1091 | ||
1092 | req = blk_make_request(pdv->pdv_sd->request_queue, hbio, | 1092 | req = blk_make_request(pdv->pdv_sd->request_queue, hbio, |
1093 | GFP_KERNEL); | 1093 | GFP_KERNEL); |
1094 | if (!req) { | 1094 | if (IS_ERR(req)) { |
1095 | pr_err("pSCSI: blk_make_request() failed\n"); | 1095 | pr_err("pSCSI: blk_make_request() failed\n"); |
1096 | goto fail; | 1096 | goto fail; |
1097 | } | 1097 | } |