target: Use array_zalloc for device_list

Turns an order-8 allocation into slab-sized ones, thereby preventing
allocation failures with memory fragmentation.

This likely saves memory as well, as the slab allocator can pack objects
more tightly than the buddy allocator.

(nab: Fix lio-core patch fuzz)

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 4 insertions, 4 deletions

diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index 146fe47f11c1..c0fecde02fd0 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -64,7 +64,7 @@ static void core_clear_initiator_node_from_tpg(
 
         spin_lock_irq(&nacl->device_list_lock);
         for (i = 0; i < TRANSPORT_MAX_LUNS_PER_TPG; i++) {
-                deve = &nacl->device_list[i];
+                deve = nacl->device_list[i];
 
                 if (!(deve->lun_flags & TRANSPORT_LUNFLAGS_INITIATOR_ACCESS))
                         continue;
@@ -259,15 +259,15 @@ static int core_create_device_list_for_node(struct se_node_acl *nacl)
         struct se_dev_entry *deve;
         int i;
 
-        nacl->device_list = kzalloc(sizeof(struct se_dev_entry) *
-                                TRANSPORT_MAX_LUNS_PER_TPG, GFP_KERNEL);
+        nacl->device_list = array_zalloc(TRANSPORT_MAX_LUNS_PER_TPG,
+                        sizeof(struct se_dev_entry), GFP_KERNEL);
         if (!nacl->device_list) {
                 pr_err("Unable to allocate memory for"
                         " struct se_node_acl->device_list\n");
                 return -ENOMEM;
         }
         for (i = 0; i < TRANSPORT_MAX_LUNS_PER_TPG; i++) {
-                deve = &nacl->device_list[i];
+                deve = nacl->device_list[i];
 
                 atomic_set(&deve->ua_count, 0);
                 atomic_set(&deve->pr_ref_count, 0);