aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target/target_core_sbc.c
diff options
context:
space:
mode:
authorNicholas Bellinger <nab@linux-iscsi.org>2015-02-13 17:27:40 -0500
committerNicholas Bellinger <nab@linux-iscsi.org>2015-02-13 21:09:44 -0500
commitaa179935edea9a64dec4b757090c8106a3907ffa (patch)
tree57898482d3a5c86e00db5b23f1b4057e4376c597 /drivers/target/target_core_sbc.c
parent8e575c50a171f2579e367a7f778f86477dfdaf49 (diff)
target: Check for LBA + sectors wrap-around in sbc_parse_cdb
This patch adds a check to sbc_parse_cdb() in order to detect when an LBA + sector vs. end-of-device calculation wraps when the LBA is sufficently large enough (eg: 0xFFFFFFFFFFFFFFFF). Cc: Martin Petersen <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de> Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_sbc.c')
-rw-r--r--drivers/target/target_core_sbc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index b26b52f441a1..17259c05450e 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -982,7 +982,8 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
982 } 982 }
983check_lba: 983check_lba:
984 end_lba = dev->transport->get_blocks(dev) + 1; 984 end_lba = dev->transport->get_blocks(dev) + 1;
985 if (cmd->t_task_lba + sectors > end_lba) { 985 if (((cmd->t_task_lba + sectors) < cmd->t_task_lba) ||
986 ((cmd->t_task_lba + sectors) > end_lba)) {
986 pr_err("cmd exceeds last lba %llu " 987 pr_err("cmd exceeds last lba %llu "
987 "(lba %llu, sectors %u)\n", 988 "(lba %llu, sectors %u)\n",
988 end_lba, cmd->t_task_lba, sectors); 989 end_lba, cmd->t_task_lba, sectors);