aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target/loopback
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2014-11-13 08:25:11 -0500
committerChristoph Hellwig <hch@lst.de>2014-11-24 08:45:12 -0500
commitc40ecc12cfdb630332198a04e2832ae8218a61f1 (patch)
tree881456a7d46ca017dba4cc003e2fe1be427614fc /drivers/target/loopback
parent89dac7bb3b0494685241369951f95494e86ee61f (diff)
scsi: avoid ->change_queue_depth indirection for queue full tracking
All drivers use the implementation for ramping the queue up and down, so instead of overloading the change_queue_depth method call the implementation diretly if the driver opts into it by setting the track_queue_depth flag in the host template. Note that a few drivers validated the new queue depth in their change_queue_depth method, but as we never go over the queue depth set during slave_configure or the sysfs file this isn't nessecary and can safely be removed. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
Diffstat (limited to 'drivers/target/loopback')
-rw-r--r--drivers/target/loopback/tcm_loop.c15
1 files changed, 2 insertions, 13 deletions
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 0ed96644ec94..670b75a62243 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -119,19 +119,7 @@ static int tcm_loop_change_queue_depth(
119 int depth, 119 int depth,
120 int reason) 120 int reason)
121{ 121{
122 switch (reason) { 122 scsi_adjust_queue_depth(sdev, depth);
123 case SCSI_QDEPTH_DEFAULT:
124 scsi_adjust_queue_depth(sdev, depth);
125 break;
126 case SCSI_QDEPTH_QFULL:
127 scsi_track_queue_full(sdev, depth);
128 break;
129 case SCSI_QDEPTH_RAMP_UP:
130 scsi_adjust_queue_depth(sdev, depth);
131 break;
132 default:
133 return -EOPNOTSUPP;
134 }
135 return sdev->queue_depth; 123 return sdev->queue_depth;
136} 124}
137 125
@@ -423,6 +411,7 @@ static struct scsi_host_template tcm_loop_driver_template = {
423 .slave_alloc = tcm_loop_slave_alloc, 411 .slave_alloc = tcm_loop_slave_alloc,
424 .module = THIS_MODULE, 412 .module = THIS_MODULE,
425 .use_blk_tags = 1, 413 .use_blk_tags = 1,
414 .track_queue_depth = 1,
426}; 415};
427 416
428static int tcm_loop_driver_probe(struct device *dev) 417static int tcm_loop_driver_probe(struct device *dev)