target: Remove session_reinstatement parameter from ->transport_wait_for_tasks

This patch removes the unnecessary session_reinstatement parameter from
se_cmd->transport_wait_for_tasks(), logic in transport_generic_wait_for_tasks,
and usage within iscsi-target code.

This also includes the removal of the 'bool' return from transport_put_cmd() +
transport_generic_free_cmd() that is no longer necessary.

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 7 insertions, 8 deletions

diff --git a/drivers/target/iscsi/iscsi_target_erl2.c b/drivers/target/iscsi/iscsi_target_erl2.c
index 91a4d170bda4..000356baf0b5 100644
--- a/drivers/target/iscsi/iscsi_target_erl2.c
+++ b/drivers/target/iscsi/iscsi_target_erl2.c
@@ -148,7 +148,7 @@ void iscsit_free_connection_recovery_entires(struct iscsi_session *sess)
                                 iscsit_release_cmd(cmd);
                         else
                                 cmd->se_cmd.transport_wait_for_tasks(
-                                                &cmd->se_cmd, 1, 1);
+                                                &cmd->se_cmd, 1);
                         spin_lock(&cr->conn_recovery_cmd_lock);
                 }
                 spin_unlock(&cr->conn_recovery_cmd_lock);
@@ -175,7 +175,7 @@ void iscsit_free_connection_recovery_entires(struct iscsi_session *sess)
                                 iscsit_release_cmd(cmd);
                         else
                                 cmd->se_cmd.transport_wait_for_tasks(
-                                                &cmd->se_cmd, 1, 1);
+                                                &cmd->se_cmd, 1);
                         spin_lock(&cr->conn_recovery_cmd_lock);
                 }
                 spin_unlock(&cr->conn_recovery_cmd_lock);
@@ -265,7 +265,7 @@ void iscsit_discard_cr_cmds_by_expstatsn(
                         iscsit_release_cmd(cmd);
                 else
                         cmd->se_cmd.transport_wait_for_tasks(
-                                        &cmd->se_cmd, 1, 0);
+                                        &cmd->se_cmd, 1);
                 spin_lock(&cr->conn_recovery_cmd_lock);
         }
         spin_unlock(&cr->conn_recovery_cmd_lock);
@@ -324,7 +324,7 @@ int iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(struct iscsi_conn *conn)
                         iscsit_release_cmd(cmd);
                 else
                         cmd->se_cmd.transport_wait_for_tasks(
-                                        &cmd->se_cmd, 1, 1);
+                                        &cmd->se_cmd, 1);
                 spin_lock_bh(&conn->cmd_lock);
         }
         spin_unlock_bh(&conn->cmd_lock);
@@ -383,7 +383,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn)
                                 iscsit_release_cmd(cmd);
                         else
                                 cmd->se_cmd.transport_wait_for_tasks(
-                                                &cmd->se_cmd, 1, 0);
+                                                &cmd->se_cmd, 1);
                         spin_lock_bh(&conn->cmd_lock);
                         continue;
                 }
@@ -409,7 +409,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn)
                                 iscsit_release_cmd(cmd);
                         else
                                 cmd->se_cmd.transport_wait_for_tasks(
-                                                &cmd->se_cmd, 1, 1);
+                                                &cmd->se_cmd, 1);
                         spin_lock_bh(&conn->cmd_lock);
                         continue;
                 }
@@ -436,8 +436,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn)
 
                 if ((cmd->se_cmd.se_cmd_flags & SCF_SE_LUN_CMD) &&
                      cmd->se_cmd.transport_wait_for_tasks)
-                        cmd->se_cmd.transport_wait_for_tasks(&cmd->se_cmd,
-                                        0, 0);
+                        cmd->se_cmd.transport_wait_for_tasks(&cmd->se_cmd, 0);
                 /*
                  * Add the struct iscsi_cmd to the connection recovery cmd list
                  */