diff options
| author | Haiyang Zhang <haiyangz@microsoft.com> | 2010-05-13 11:56:30 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-14 16:57:56 -0400 |
| commit | fd4dc88e46c4d9dd845ffef50a975ceea110fd85 (patch) | |
| tree | 8f0aed81475895faa4f15838dbddb07285b3b6ae /drivers/staging | |
| parent | 3dfe08e6073f40a742fe3e5d6b43ca8184c55722 (diff) | |
staging: hv: Fix error checking in channel.c
Fixed errors in return value checking code, which caused vmbus channel
not functioning.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Cc: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/hv/channel.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/hv/channel.c b/drivers/staging/hv/channel.c index 12c351e16360..f047c5a7f64c 100644 --- a/drivers/staging/hv/channel.c +++ b/drivers/staging/hv/channel.c | |||
| @@ -204,13 +204,13 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize, | |||
| 204 | RecvRingBufferSize) >> PAGE_SHIFT; | 204 | RecvRingBufferSize) >> PAGE_SHIFT; |
| 205 | 205 | ||
| 206 | ret = RingBufferInit(&NewChannel->Outbound, out, SendRingBufferSize); | 206 | ret = RingBufferInit(&NewChannel->Outbound, out, SendRingBufferSize); |
| 207 | if (!ret) { | 207 | if (ret != 0) { |
| 208 | err = ret; | 208 | err = ret; |
| 209 | goto errorout; | 209 | goto errorout; |
| 210 | } | 210 | } |
| 211 | 211 | ||
| 212 | ret = RingBufferInit(&NewChannel->Inbound, in, RecvRingBufferSize); | 212 | ret = RingBufferInit(&NewChannel->Inbound, in, RecvRingBufferSize); |
| 213 | if (!ret) { | 213 | if (ret != 0) { |
| 214 | err = ret; | 214 | err = ret; |
| 215 | goto errorout; | 215 | goto errorout; |
| 216 | } | 216 | } |
| @@ -228,7 +228,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize, | |||
| 228 | RecvRingBufferSize, | 228 | RecvRingBufferSize, |
| 229 | &NewChannel->RingBufferGpadlHandle); | 229 | &NewChannel->RingBufferGpadlHandle); |
| 230 | 230 | ||
| 231 | if (!ret) { | 231 | if (ret != 0) { |
| 232 | err = ret; | 232 | err = ret; |
| 233 | goto errorout; | 233 | goto errorout; |
| 234 | } | 234 | } |
| @@ -569,7 +569,7 @@ int VmbusChannelEstablishGpadl(struct vmbus_channel *Channel, void *Kbuffer, | |||
| 569 | ret = VmbusPostMessage(gpadlBody, | 569 | ret = VmbusPostMessage(gpadlBody, |
| 570 | subMsgInfo->MessageSize - | 570 | subMsgInfo->MessageSize - |
| 571 | sizeof(*subMsgInfo)); | 571 | sizeof(*subMsgInfo)); |
| 572 | if (!ret) | 572 | if (ret != 0) |
| 573 | goto Cleanup; | 573 | goto Cleanup; |
| 574 | 574 | ||
| 575 | } | 575 | } |
