diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-04-05 08:06:35 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-04-05 12:43:29 -0400 |
commit | a18ac314ebff427b972a0bb5ddfc205b8145e04e (patch) | |
tree | a3cd6f3e177c6242e6a559aed9ce420a6f98ca39 /drivers/staging | |
parent | b183c11217e10c274720795daed5703c2186a459 (diff) |
staging: lustre: lnet: lnet: fix error return code
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r-- | drivers/staging/lustre/lnet/lnet/api-ni.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c index faceb9505d84..4a14e5109821 100644 --- a/drivers/staging/lustre/lnet/lnet/api-ni.c +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c | |||
@@ -650,15 +650,19 @@ lnet_prepare(lnet_pid_t requested_pid) | |||
650 | 650 | ||
651 | recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, | 651 | recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, |
652 | sizeof(lnet_me_t)); | 652 | sizeof(lnet_me_t)); |
653 | if (recs == NULL) | 653 | if (recs == NULL) { |
654 | rc = -ENOMEM; | ||
654 | goto failed; | 655 | goto failed; |
656 | } | ||
655 | 657 | ||
656 | the_lnet.ln_me_containers = recs; | 658 | the_lnet.ln_me_containers = recs; |
657 | 659 | ||
658 | recs = lnet_res_containers_create(LNET_COOKIE_TYPE_MD, LNET_FL_MAX_MDS, | 660 | recs = lnet_res_containers_create(LNET_COOKIE_TYPE_MD, LNET_FL_MAX_MDS, |
659 | sizeof(lnet_libmd_t)); | 661 | sizeof(lnet_libmd_t)); |
660 | if (recs == NULL) | 662 | if (recs == NULL) { |
663 | rc = -ENOMEM; | ||
661 | goto failed; | 664 | goto failed; |
665 | } | ||
662 | 666 | ||
663 | the_lnet.ln_md_containers = recs; | 667 | the_lnet.ln_md_containers = recs; |
664 | 668 | ||