diff options
author | Federico Vaga <federico.vaga@gmail.com> | 2011-10-29 03:47:39 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-26 21:34:15 -0500 |
commit | 6a9ce6b654e491981f6ef7e214cbd4f63e033848 (patch) | |
tree | b1b2abec9775fc135d899b08351ac520a1197806 /drivers/staging | |
parent | df30b21cb0eed5ba8a8e0cdfeebc66ba8cde821d (diff) |
Staging: comedi: fix signal handling in read and write
After sleeping on a wait queue, signal_pending(current) should be
checked (not before sleeping).
Acked-by: Alessandro Rubini <rubini@gnudd.com>
Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
-rw-r--r-- | drivers/staging/comedi/comedi_fops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 88caa7376999..ebdcecda3583 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c | |||
@@ -1673,11 +1673,11 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, | |||
1673 | retval = -EAGAIN; | 1673 | retval = -EAGAIN; |
1674 | break; | 1674 | break; |
1675 | } | 1675 | } |
1676 | schedule(); | ||
1676 | if (signal_pending(current)) { | 1677 | if (signal_pending(current)) { |
1677 | retval = -ERESTARTSYS; | 1678 | retval = -ERESTARTSYS; |
1678 | break; | 1679 | break; |
1679 | } | 1680 | } |
1680 | schedule(); | ||
1681 | if (!s->busy) | 1681 | if (!s->busy) |
1682 | break; | 1682 | break; |
1683 | if (s->busy != file) { | 1683 | if (s->busy != file) { |
@@ -1780,11 +1780,11 @@ static ssize_t comedi_read(struct file *file, char __user *buf, size_t nbytes, | |||
1780 | retval = -EAGAIN; | 1780 | retval = -EAGAIN; |
1781 | break; | 1781 | break; |
1782 | } | 1782 | } |
1783 | schedule(); | ||
1783 | if (signal_pending(current)) { | 1784 | if (signal_pending(current)) { |
1784 | retval = -ERESTARTSYS; | 1785 | retval = -ERESTARTSYS; |
1785 | break; | 1786 | break; |
1786 | } | 1787 | } |
1787 | schedule(); | ||
1788 | if (!s->busy) { | 1788 | if (!s->busy) { |
1789 | retval = 0; | 1789 | retval = 0; |
1790 | break; | 1790 | break; |