aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorMark Einon <mark.einon@gmail.com>2011-10-19 20:18:45 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2011-10-23 04:07:12 -0400
commit26d19bf60be3a41bbd6c31d89d13a9c5e8edef8b (patch)
tree7b7764099f323e6471a4901f43d3ccbb5fd9410f /drivers/staging
parent675c8f68ca65632624c0ebc03788f53c2109bf5b (diff)
staging: et131x: Tidy up PCI device table definition
Used the convenience macros DEFINE_PCI_DEVICE_TABLE and PCI_VDEVICE to tidy up the device table definition. Also remove the corresponding TODO item from the README. Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/et131x/README1
-rw-r--r--drivers/staging/et131x/et131x.c12
2 files changed, 4 insertions, 9 deletions
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 87b936012656..0928eb55fee1 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
@@ -10,7 +10,6 @@ driver as they did not build properly at the time.
10TODO: 10TODO:
11 - Use of kmem_cache seems a bit unusual 11 - Use of kmem_cache seems a bit unusual
12 - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. 12 - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
13 - PCI_VDEVICE ?
14 13
15Please send patches to: 14Please send patches to:
16 Greg Kroah-Hartman <gregkh@suse.de> 15 Greg Kroah-Hartman <gregkh@suse.de>
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 28d54b31e437..cc41111b7b70 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -169,8 +169,7 @@ MODULE_DESCRIPTION("10/100/1000 Base-T Ethernet Driver "
169#define ET1310_PCI_REPLAY 0xC2 169#define ET1310_PCI_REPLAY 0xC2
170#define ET1310_PCI_L0L1LATENCY 0xCF 170#define ET1310_PCI_L0L1LATENCY 0xCF
171 171
172/* PCI Vendor/Product IDs */ 172/* PCI Product IDs */
173#define ET131X_PCI_VENDOR_ID 0x11C1 /* Agere Systems */
174#define ET131X_PCI_DEVICE_ID_GIG 0xED00 /* ET1310 1000 Base-T 8 */ 173#define ET131X_PCI_DEVICE_ID_GIG 0xED00 /* ET1310 1000 Base-T 8 */
175#define ET131X_PCI_DEVICE_ID_FAST 0xED01 /* ET1310 100 Base-T */ 174#define ET131X_PCI_DEVICE_ID_FAST 0xED01 /* ET1310 100 Base-T */
176 175
@@ -4647,14 +4646,11 @@ static SIMPLE_DEV_PM_OPS(et131x_pm_ops, et131x_suspend, et131x_resume);
4647#define ET131X_PM_OPS NULL 4646#define ET131X_PM_OPS NULL
4648#endif 4647#endif
4649 4648
4650static struct pci_device_id et131x_pci_table[] __devinitdata = { 4649static DEFINE_PCI_DEVICE_TABLE(et131x_pci_table) = {
4651 {ET131X_PCI_VENDOR_ID, ET131X_PCI_DEVICE_ID_GIG, PCI_ANY_ID, 4650 { PCI_VDEVICE(ATT, ET131X_PCI_DEVICE_ID_GIG), 0UL},
4652 PCI_ANY_ID, 0, 0, 0UL}, 4651 { PCI_VDEVICE(ATT, ET131X_PCI_DEVICE_ID_FAST), 0UL},
4653 {ET131X_PCI_VENDOR_ID, ET131X_PCI_DEVICE_ID_FAST, PCI_ANY_ID,
4654 PCI_ANY_ID, 0, 0, 0UL},
4655 {0,} 4652 {0,}
4656}; 4653};
4657
4658MODULE_DEVICE_TABLE(pci, et131x_pci_table); 4654MODULE_DEVICE_TABLE(pci, et131x_pci_table);
4659 4655
4660static struct pci_driver et131x_driver = { 4656static struct pci_driver et131x_driver = {