aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2010-03-02 17:51:53 -0500
committerEric W. Biederman <ebiederm@xmission.com>2012-11-19 08:59:09 -0500
commit17cf22c33e1f1b5e435469c84e43872579497653 (patch)
treec5cec307c06f7e4ddc26e04e73c8833897b67113 /drivers/staging
parent49f4d8b93ccf9454284b6f524b96c66d8d7fbccc (diff)
pidns: Use task_active_pid_ns where appropriate
The expressions tsk->nsproxy->pid_ns and task_active_pid_ns aka ns_of_pid(task_pid(tsk)) should have the same number of cache line misses with the practical difference that ns_of_pid(task_pid(tsk)) is released later in a processes life. Furthermore by using task_active_pid_ns it becomes trivial to write an unshare implementation for the the pid namespace. So I have used task_active_pid_ns everywhere I can. In fork since the pid has not yet been attached to the process I use ns_of_pid, to achieve the same effect. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/android/binder.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 5d4610babd8a..a97bbcd1c9ea 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -33,6 +33,7 @@
33#include <linux/uaccess.h> 33#include <linux/uaccess.h>
34#include <linux/vmalloc.h> 34#include <linux/vmalloc.h>
35#include <linux/slab.h> 35#include <linux/slab.h>
36#include <linux/pid_namespace.h>
36 37
37#include "binder.h" 38#include "binder.h"
38 39
@@ -2344,7 +2345,7 @@ retry:
2344 if (t->from) { 2345 if (t->from) {
2345 struct task_struct *sender = t->from->proc->tsk; 2346 struct task_struct *sender = t->from->proc->tsk;
2346 tr.sender_pid = task_tgid_nr_ns(sender, 2347 tr.sender_pid = task_tgid_nr_ns(sender,
2347 current->nsproxy->pid_ns); 2348 task_active_pid_ns(current));
2348 } else { 2349 } else {
2349 tr.sender_pid = 0; 2350 tr.sender_pid = 0;
2350 } 2351 }