aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/spi
diff options
context:
space:
mode:
authorLaxman Dewangan <ldewangan@nvidia.com>2012-11-23 04:22:39 -0500
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-04-01 09:34:44 -0400
commitfaa98f7ea6c720beec8a800c9ac6975f760467e2 (patch)
tree2a5f58b598e92e4b540194759ac0ab6cc8e79bac /drivers/spi
parent8179bb2655b607d4c3e8cea10a60eb3cf8557b63 (diff)
spi: tegra: slink: do not prepare dma transfer with DMA_CTRL_ACK flag
Spi starts transfer using dma with DMA_CTRL_ACK which is not require becasue spi driver does not use completed dma_desc after transfer done and so it does not ack the dma descriptor. Removing the DMA_CTRL_ACK flag to avoid memory leak in dma driver. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/spi')
-rw-r--r--drivers/spi/spi-tegra20-slink.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 17224f0f4d56..4e58b5399037 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -467,7 +467,7 @@ static int tegra_slink_start_tx_dma(struct tegra_slink_data *tspi, int len)
467 INIT_COMPLETION(tspi->tx_dma_complete); 467 INIT_COMPLETION(tspi->tx_dma_complete);
468 tspi->tx_dma_desc = dmaengine_prep_slave_single(tspi->tx_dma_chan, 468 tspi->tx_dma_desc = dmaengine_prep_slave_single(tspi->tx_dma_chan,
469 tspi->tx_dma_phys, len, DMA_MEM_TO_DEV, 469 tspi->tx_dma_phys, len, DMA_MEM_TO_DEV,
470 DMA_PREP_INTERRUPT | DMA_CTRL_ACK); 470 DMA_PREP_INTERRUPT);
471 if (!tspi->tx_dma_desc) { 471 if (!tspi->tx_dma_desc) {
472 dev_err(tspi->dev, "Not able to get desc for Tx\n"); 472 dev_err(tspi->dev, "Not able to get desc for Tx\n");
473 return -EIO; 473 return -EIO;
@@ -486,7 +486,7 @@ static int tegra_slink_start_rx_dma(struct tegra_slink_data *tspi, int len)
486 INIT_COMPLETION(tspi->rx_dma_complete); 486 INIT_COMPLETION(tspi->rx_dma_complete);
487 tspi->rx_dma_desc = dmaengine_prep_slave_single(tspi->rx_dma_chan, 487 tspi->rx_dma_desc = dmaengine_prep_slave_single(tspi->rx_dma_chan,
488 tspi->rx_dma_phys, len, DMA_DEV_TO_MEM, 488 tspi->rx_dma_phys, len, DMA_DEV_TO_MEM,
489 DMA_PREP_INTERRUPT | DMA_CTRL_ACK); 489 DMA_PREP_INTERRUPT);
490 if (!tspi->rx_dma_desc) { 490 if (!tspi->rx_dma_desc) {
491 dev_err(tspi->dev, "Not able to get desc for Rx\n"); 491 dev_err(tspi->dev, "Not able to get desc for Rx\n");
492 return -EIO; 492 return -EIO;