diff options
author | Stephen Warren <swarren@wwwdotorg.org> | 2013-05-21 22:36:35 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2013-05-29 15:48:17 -0400 |
commit | 24778be20f87d5aadb19624fc768b3159fa43efc (patch) | |
tree | 05124574b6d331f34938bbae09d4014fde7dca76 /drivers/spi/spi-omap2-mcspi.c | |
parent | 2922a8de996956893bb98e4aa91be9774c958336 (diff) |
spi: convert drivers to use bits_per_word_mask
Fill in the recently added spi_master.bits_per_word_mask field in as
many drivers as possible. Make related cleanups, such as removing any
redundant error-checking, or empty setup callbacks.
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/spi/spi-omap2-mcspi.c')
-rw-r--r-- | drivers/spi/spi-omap2-mcspi.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 86d2158946bb..6246fb455774 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c | |||
@@ -857,12 +857,6 @@ static int omap2_mcspi_setup(struct spi_device *spi) | |||
857 | struct omap2_mcspi_dma *mcspi_dma; | 857 | struct omap2_mcspi_dma *mcspi_dma; |
858 | struct omap2_mcspi_cs *cs = spi->controller_state; | 858 | struct omap2_mcspi_cs *cs = spi->controller_state; |
859 | 859 | ||
860 | if (spi->bits_per_word < 4 || spi->bits_per_word > 32) { | ||
861 | dev_dbg(&spi->dev, "setup: unsupported %d bit words\n", | ||
862 | spi->bits_per_word); | ||
863 | return -EINVAL; | ||
864 | } | ||
865 | |||
866 | mcspi_dma = &mcspi->dma_channels[spi->chip_select]; | 860 | mcspi_dma = &mcspi->dma_channels[spi->chip_select]; |
867 | 861 | ||
868 | if (!cs) { | 862 | if (!cs) { |
@@ -1072,10 +1066,7 @@ static int omap2_mcspi_transfer_one_message(struct spi_master *master, | |||
1072 | unsigned len = t->len; | 1066 | unsigned len = t->len; |
1073 | 1067 | ||
1074 | if (t->speed_hz > OMAP2_MCSPI_MAX_FREQ | 1068 | if (t->speed_hz > OMAP2_MCSPI_MAX_FREQ |
1075 | || (len && !(rx_buf || tx_buf)) | 1069 | || (len && !(rx_buf || tx_buf))) { |
1076 | || (t->bits_per_word && | ||
1077 | ( t->bits_per_word < 4 | ||
1078 | || t->bits_per_word > 32))) { | ||
1079 | dev_dbg(mcspi->dev, "transfer: %d Hz, %d %s%s, %d bpw\n", | 1070 | dev_dbg(mcspi->dev, "transfer: %d Hz, %d %s%s, %d bpw\n", |
1080 | t->speed_hz, | 1071 | t->speed_hz, |
1081 | len, | 1072 | len, |
@@ -1196,7 +1187,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev) | |||
1196 | 1187 | ||
1197 | /* the spi->mode bits understood by this driver: */ | 1188 | /* the spi->mode bits understood by this driver: */ |
1198 | master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH; | 1189 | master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH; |
1199 | 1190 | master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32); | |
1200 | master->setup = omap2_mcspi_setup; | 1191 | master->setup = omap2_mcspi_setup; |
1201 | master->prepare_transfer_hardware = omap2_prepare_transfer; | 1192 | master->prepare_transfer_hardware = omap2_prepare_transfer; |
1202 | master->unprepare_transfer_hardware = omap2_unprepare_transfer; | 1193 | master->unprepare_transfer_hardware = omap2_unprepare_transfer; |