diff options
author | Stephen Warren <swarren@wwwdotorg.org> | 2013-05-21 22:36:35 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2013-05-29 15:48:17 -0400 |
commit | 24778be20f87d5aadb19624fc768b3159fa43efc (patch) | |
tree | 05124574b6d331f34938bbae09d4014fde7dca76 /drivers/spi/spi-davinci.c | |
parent | 2922a8de996956893bb98e4aa91be9774c958336 (diff) |
spi: convert drivers to use bits_per_word_mask
Fill in the recently added spi_master.bits_per_word_mask field in as
many drivers as possible. Make related cleanups, such as removing any
redundant error-checking, or empty setup callbacks.
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/spi/spi-davinci.c')
-rw-r--r-- | drivers/spi/spi-davinci.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 50b13c9b1ab6..b141ef221b14 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c | |||
@@ -299,16 +299,15 @@ static int davinci_spi_setup_transfer(struct spi_device *spi, | |||
299 | * Assign function pointer to appropriate transfer method | 299 | * Assign function pointer to appropriate transfer method |
300 | * 8bit, 16bit or 32bit transfer | 300 | * 8bit, 16bit or 32bit transfer |
301 | */ | 301 | */ |
302 | if (bits_per_word <= 8 && bits_per_word >= 2) { | 302 | if (bits_per_word <= 8) { |
303 | dspi->get_rx = davinci_spi_rx_buf_u8; | 303 | dspi->get_rx = davinci_spi_rx_buf_u8; |
304 | dspi->get_tx = davinci_spi_tx_buf_u8; | 304 | dspi->get_tx = davinci_spi_tx_buf_u8; |
305 | dspi->bytes_per_word[spi->chip_select] = 1; | 305 | dspi->bytes_per_word[spi->chip_select] = 1; |
306 | } else if (bits_per_word <= 16 && bits_per_word >= 2) { | 306 | } else { |
307 | dspi->get_rx = davinci_spi_rx_buf_u16; | 307 | dspi->get_rx = davinci_spi_rx_buf_u16; |
308 | dspi->get_tx = davinci_spi_tx_buf_u16; | 308 | dspi->get_tx = davinci_spi_tx_buf_u16; |
309 | dspi->bytes_per_word[spi->chip_select] = 2; | 309 | dspi->bytes_per_word[spi->chip_select] = 2; |
310 | } else | 310 | } |
311 | return -EINVAL; | ||
312 | 311 | ||
313 | if (!hz) | 312 | if (!hz) |
314 | hz = spi->max_speed_hz; | 313 | hz = spi->max_speed_hz; |
@@ -933,6 +932,7 @@ static int davinci_spi_probe(struct platform_device *pdev) | |||
933 | master->dev.of_node = pdev->dev.of_node; | 932 | master->dev.of_node = pdev->dev.of_node; |
934 | master->bus_num = pdev->id; | 933 | master->bus_num = pdev->id; |
935 | master->num_chipselect = pdata->num_chipselect; | 934 | master->num_chipselect = pdata->num_chipselect; |
935 | master->bits_per_word_mask = SPI_BPW_RANGE_MASK(2, 16); | ||
936 | master->setup = davinci_spi_setup; | 936 | master->setup = davinci_spi_setup; |
937 | 937 | ||
938 | dspi->bitbang.chipselect = davinci_spi_chipselect; | 938 | dspi->bitbang.chipselect = davinci_spi_chipselect; |