[POWERPC] cpm_uart: sparse fixes

Mostly a bunch of direct access to in/out conversions, plus a few
cast removals, __iomem annotations, and miscellaneous cleanup.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

1 files changed, 22 insertions, 20 deletions

diff --git a/drivers/serial/cpm_uart/cpm_uart.h b/drivers/serial/cpm_uart/cpm_uart.h
index 4e1987adc23b..32b9737759c4 100644
--- a/drivers/serial/cpm_uart/cpm_uart.h
+++ b/drivers/serial/cpm_uart/cpm_uart.h
@@ -56,21 +56,21 @@ struct uart_cpm_port {
         u16                     rx_fifosize;
         u16                     tx_nrfifos;
         u16                     tx_fifosize;
-        smc_t                   *smcp;
-        smc_uart_t              *smcup;
-        scc_t                   *sccp;
-        scc_uart_t              *sccup;
-        volatile cbd_t          *rx_bd_base;
-        volatile cbd_t          *rx_cur;
-        volatile cbd_t          *tx_bd_base;
-        volatile cbd_t          *tx_cur;
+        smc_t __iomem           *smcp;
+        smc_uart_t __iomem      *smcup;
+        scc_t __iomem           *sccp;
+        scc_uart_t __iomem      *sccup;
+        cbd_t __iomem           *rx_bd_base;
+        cbd_t __iomem           *rx_cur;
+        cbd_t __iomem           *tx_bd_base;
+        cbd_t __iomem           *tx_cur;
         unsigned char           *tx_buf;
         unsigned char           *rx_buf;
         u32                     flags;
         void                    (*set_lineif)(struct uart_cpm_port *);
         u8                      brg;
         uint                     dp_addr;
-        void                    *mem_addr;
+        void                    *mem_addr;
         dma_addr_t               dma_addr;
         u32                     mem_size;
         /* helpers */
@@ -106,34 +106,36 @@ void scc4_lineif(struct uart_cpm_port *pinfo);
 /*
    virtual to phys transtalion
 */
-static inline unsigned long cpu2cpm_addr(void* addr, struct uart_cpm_port *pinfo)
+static inline unsigned long cpu2cpm_addr(void *addr,
+                                         struct uart_cpm_port *pinfo)
 {
         int offset;
         u32 val = (u32)addr;
+        u32 mem = (u32)pinfo->mem_addr;
         /* sane check */
-        if (likely((val >= (u32)pinfo->mem_addr)) &&
-                        (val<((u32)pinfo->mem_addr + pinfo->mem_size))) {
-                offset = val - (u32)pinfo->mem_addr;
-                return pinfo->dma_addr+offset;
+        if (likely(val >= mem && val < mem + pinfo->mem_size)) {
+                offset = val - mem;
+                return pinfo->dma_addr + offset;
         }
         /* something nasty happened */
         BUG();
         return 0;
 }
 
-static inline void *cpm2cpu_addr(unsigned long addr, struct uart_cpm_port *pinfo)
+static inline void *cpm2cpu_addr(unsigned long addr,
+                                 struct uart_cpm_port *pinfo)
 {
         int offset;
         u32 val = addr;
+        u32 dma = (u32)pinfo->dma_addr;
         /* sane check */
-        if (likely((val >= pinfo->dma_addr) &&
-                        (val<(pinfo->dma_addr + pinfo->mem_size)))) {
-                offset = val - (u32)pinfo->dma_addr;
-                return (void*)(pinfo->mem_addr+offset);
+        if (likely(val >= dma && val < dma + pinfo->mem_size)) {
+                offset = val - dma;
+                return pinfo->mem_addr + offset;
         }
         /* something nasty happened */
         BUG();
-        return 0;
+        return NULL;
 }