diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-22 22:22:50 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-22 22:22:50 -0400 |
commit | e8650a08232e75274304b812ff04cfce9af9671c (patch) | |
tree | 0609c942e6ca99016e788ff2ee2bbed1bb9215a4 /drivers/scsi | |
parent | 3c2c4b73aa79e4a1b601710b59e092441175f4bb (diff) | |
parent | f70d4a95edc7da87f39cd8b603ba131df2c198ed (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
Pull trivial updates from Jiri Kosina:
"As usual, it's mostly typo fixes, redundant code elimination and some
documentation updates."
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (57 commits)
edac, mips: don't change code that has been removed in edac/mips tree
xtensa: Change mail addresses of Hannes Weiner and Oskar Schirmer
lib: Change mail address of Oskar Schirmer
net: Change mail address of Oskar Schirmer
arm/m68k: Change mail address of Sebastian Hess
i2c: Change mail address of Oskar Schirmer
net: Fix tcp_build_and_update_options comment in struct tcp_sock
atomic64_32.h: fix parameter naming mismatch
Kconfig: replace "--- help ---" with "---help---"
c2port: fix bogus Kconfig "default no"
edac: Fix spelling errors.
qla1280: Remove redundant NULL check before release_firmware() call
remoteproc: remove redundant NULL check before release_firmware()
qla2xxx: Remove redundant NULL check before release_firmware() call.
aic94xx: Get rid of redundant NULL check before release_firmware() call
tehuti: delete redundant NULL check before release_firmware()
qlogic: get rid of a redundant test for NULL before call to release_firmware()
bna: remove redundant NULL test before release_firmware()
tg3: remove redundant NULL test before release_firmware() call
typhoon: get rid of redundant conditional before all to release_firmware()
...
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/aic94xx/aic94xx_seq.c | 3 | ||||
-rw-r--r-- | drivers/scsi/esp_scsi.c | 2 | ||||
-rw-r--r-- | drivers/scsi/qla1280.c | 7 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 3 | ||||
-rw-r--r-- | drivers/scsi/scsi_error.c | 6 |
5 files changed, 8 insertions, 13 deletions
diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c index 390168f62a13..5fdca93892ad 100644 --- a/drivers/scsi/aic94xx/aic94xx_seq.c +++ b/drivers/scsi/aic94xx/aic94xx_seq.c | |||
@@ -1228,8 +1228,7 @@ static int asd_seq_start_lseq(struct asd_ha_struct *asd_ha, int lseq) | |||
1228 | 1228 | ||
1229 | int asd_release_firmware(void) | 1229 | int asd_release_firmware(void) |
1230 | { | 1230 | { |
1231 | if (sequencer_fw) | 1231 | release_firmware(sequencer_fw); |
1232 | release_firmware(sequencer_fw); | ||
1233 | return 0; | 1232 | return 0; |
1234 | } | 1233 | } |
1235 | 1234 | ||
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c index 394ed9e79fd4..34552bf1c023 100644 --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c | |||
@@ -1000,7 +1000,7 @@ static int esp_check_spur_intr(struct esp *esp) | |||
1000 | 1000 | ||
1001 | static void esp_schedule_reset(struct esp *esp) | 1001 | static void esp_schedule_reset(struct esp *esp) |
1002 | { | 1002 | { |
1003 | esp_log_reset("ESP: esp_schedule_reset() from %p\n", | 1003 | esp_log_reset("ESP: esp_schedule_reset() from %pf\n", |
1004 | __builtin_return_address(0)); | 1004 | __builtin_return_address(0)); |
1005 | esp->flags |= ESP_FLAG_RESETTING; | 1005 | esp->flags |= ESP_FLAG_RESETTING; |
1006 | esp_event(esp, ESP_EVENT_RESET); | 1006 | esp_event(esp, ESP_EVENT_RESET); |
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 6c6486f626ee..538230be5cca 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c | |||
@@ -4473,17 +4473,14 @@ qla1280_exit(void) | |||
4473 | pci_unregister_driver(&qla1280_pci_driver); | 4473 | pci_unregister_driver(&qla1280_pci_driver); |
4474 | /* release any allocated firmware images */ | 4474 | /* release any allocated firmware images */ |
4475 | for (i = 0; i < QL_NUM_FW_IMAGES; i++) { | 4475 | for (i = 0; i < QL_NUM_FW_IMAGES; i++) { |
4476 | if (qla1280_fw_tbl[i].fw) { | 4476 | release_firmware(qla1280_fw_tbl[i].fw); |
4477 | release_firmware(qla1280_fw_tbl[i].fw); | 4477 | qla1280_fw_tbl[i].fw = NULL; |
4478 | qla1280_fw_tbl[i].fw = NULL; | ||
4479 | } | ||
4480 | } | 4478 | } |
4481 | } | 4479 | } |
4482 | 4480 | ||
4483 | module_init(qla1280_init); | 4481 | module_init(qla1280_init); |
4484 | module_exit(qla1280_exit); | 4482 | module_exit(qla1280_exit); |
4485 | 4483 | ||
4486 | |||
4487 | MODULE_AUTHOR("Qlogic & Jes Sorensen"); | 4484 | MODULE_AUTHOR("Qlogic & Jes Sorensen"); |
4488 | MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); | 4485 | MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); |
4489 | MODULE_LICENSE("GPL"); | 4486 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 7db803377c64..c9c56a8427f3 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c | |||
@@ -4122,8 +4122,7 @@ qla2x00_release_firmware(void) | |||
4122 | 4122 | ||
4123 | mutex_lock(&qla_fw_lock); | 4123 | mutex_lock(&qla_fw_lock); |
4124 | for (idx = 0; idx < FW_BLOBS; idx++) | 4124 | for (idx = 0; idx < FW_BLOBS; idx++) |
4125 | if (qla_fw_blobs[idx].fw) | 4125 | release_firmware(qla_fw_blobs[idx].fw); |
4126 | release_firmware(qla_fw_blobs[idx].fw); | ||
4127 | mutex_unlock(&qla_fw_lock); | 4126 | mutex_unlock(&qla_fw_lock); |
4128 | } | 4127 | } |
4129 | 4128 | ||
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 386f0c53bea7..d0f71e5d065f 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -664,7 +664,7 @@ static void scsi_abort_eh_cmnd(struct scsi_cmnd *scmd) | |||
664 | } | 664 | } |
665 | 665 | ||
666 | /** | 666 | /** |
667 | * scsi_eh_prep_cmnd - Save a scsi command info as part of error recory | 667 | * scsi_eh_prep_cmnd - Save a scsi command info as part of error recovery |
668 | * @scmd: SCSI command structure to hijack | 668 | * @scmd: SCSI command structure to hijack |
669 | * @ses: structure to save restore information | 669 | * @ses: structure to save restore information |
670 | * @cmnd: CDB to send. Can be NULL if no new cmnd is needed | 670 | * @cmnd: CDB to send. Can be NULL if no new cmnd is needed |
@@ -739,7 +739,7 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, | |||
739 | EXPORT_SYMBOL(scsi_eh_prep_cmnd); | 739 | EXPORT_SYMBOL(scsi_eh_prep_cmnd); |
740 | 740 | ||
741 | /** | 741 | /** |
742 | * scsi_eh_restore_cmnd - Restore a scsi command info as part of error recory | 742 | * scsi_eh_restore_cmnd - Restore a scsi command info as part of error recovery |
743 | * @scmd: SCSI command structure to restore | 743 | * @scmd: SCSI command structure to restore |
744 | * @ses: saved information from a coresponding call to scsi_eh_prep_cmnd | 744 | * @ses: saved information from a coresponding call to scsi_eh_prep_cmnd |
745 | * | 745 | * |
@@ -762,7 +762,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) | |||
762 | EXPORT_SYMBOL(scsi_eh_restore_cmnd); | 762 | EXPORT_SYMBOL(scsi_eh_restore_cmnd); |
763 | 763 | ||
764 | /** | 764 | /** |
765 | * scsi_send_eh_cmnd - submit a scsi command as part of error recory | 765 | * scsi_send_eh_cmnd - submit a scsi command as part of error recovery |
766 | * @scmd: SCSI command structure to hijack | 766 | * @scmd: SCSI command structure to hijack |
767 | * @cmnd: CDB to send | 767 | * @cmnd: CDB to send |
768 | * @cmnd_size: size in bytes of @cmnd | 768 | * @cmnd_size: size in bytes of @cmnd |