diff options
author | Yi Zou <yi.zou@intel.com> | 2012-01-13 20:26:30 -0500 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-01-16 03:47:18 -0500 |
commit | 76ffe8a3f766358a0ade543153625b3e4e66159d (patch) | |
tree | 003d5be7447e0a4ac75b00c890f75c3cd406b3e7 /drivers/scsi | |
parent | 7c9c684160bc2c6668abbd2701b440e18bb9ef35 (diff) |
[SCSI] libfc: remove redundant timer init for fcp
The fcp timer is already initialized when it gets allocated.
Signed-off-by: Yi Zou <yi.zou@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/libfc/fc_fcp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 221875ec3d7c..f607314810ac 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c | |||
@@ -155,6 +155,7 @@ static struct fc_fcp_pkt *fc_fcp_pkt_alloc(struct fc_lport *lport, gfp_t gfp) | |||
155 | fsp->xfer_ddp = FC_XID_UNKNOWN; | 155 | fsp->xfer_ddp = FC_XID_UNKNOWN; |
156 | atomic_set(&fsp->ref_cnt, 1); | 156 | atomic_set(&fsp->ref_cnt, 1); |
157 | init_timer(&fsp->timer); | 157 | init_timer(&fsp->timer); |
158 | fsp->timer.data = (unsigned long)fsp; | ||
158 | INIT_LIST_HEAD(&fsp->list); | 159 | INIT_LIST_HEAD(&fsp->list); |
159 | spin_lock_init(&fsp->scsi_pkt_lock); | 160 | spin_lock_init(&fsp->scsi_pkt_lock); |
160 | } | 161 | } |
@@ -1850,9 +1851,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) | |||
1850 | } | 1851 | } |
1851 | put_cpu(); | 1852 | put_cpu(); |
1852 | 1853 | ||
1853 | init_timer(&fsp->timer); | ||
1854 | fsp->timer.data = (unsigned long)fsp; | ||
1855 | |||
1856 | /* | 1854 | /* |
1857 | * send it to the lower layer | 1855 | * send it to the lower layer |
1858 | * if we get -1 return then put the request in the pending | 1856 | * if we get -1 return then put the request in the pending |