aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2014-06-05 17:29:47 -0400
committerChristoph Hellwig <hch@lst.de>2014-07-25 17:16:55 -0400
commit6ea8631dc2734a780aafd440bc3628fe04975252 (patch)
treebe476bba987f023da75b80eea2a3c99639847d86 /drivers/scsi
parentc86d1ae254eeb4976b81d17153b37d53b2f58004 (diff)
pas16: don't call free_dma()
The pas16 scsi driver does not use DMA, and the call to free_dma() in its exit function seems to have been copied incorrectly from another driver but never caused trouble. One case where it gets in the way is randconfig builds on ARM, which depending on the configuration does not provide a free_dma() function, causing this build error: drivers/scsi/pas16.c: In function 'pas16_release': drivers/scsi/pas16.c:611:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration] free_dma(shost->dma_channel); Removing the incorrect function calls should be the obvious fix for this, with no downsides. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/pas16.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c
index 0d78a4d5576c..80bacb5dc1d4 100644
--- a/drivers/scsi/pas16.c
+++ b/drivers/scsi/pas16.c
@@ -607,8 +607,6 @@ static int pas16_release(struct Scsi_Host *shost)
607 if (shost->irq) 607 if (shost->irq)
608 free_irq(shost->irq, shost); 608 free_irq(shost->irq, shost);
609 NCR5380_exit(shost); 609 NCR5380_exit(shost);
610 if (shost->dma_channel != 0xff)
611 free_dma(shost->dma_channel);
612 if (shost->io_port && shost->n_io_port) 610 if (shost->io_port && shost->n_io_port)
613 release_region(shost->io_port, shost->n_io_port); 611 release_region(shost->io_port, shost->n_io_port);
614 scsi_unregister(shost); 612 scsi_unregister(shost);