diff options
author | Bart Van Assche <bvanassche@acm.org> | 2013-06-25 11:27:26 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2013-07-08 12:29:21 -0400 |
commit | 4e541debb8f8746bd61f41cbb129ce9c6987b9d8 (patch) | |
tree | 84b3b42fec0a4f1b95a4efe75eca304d1adeb9f6 /drivers/scsi | |
parent | c5dcfaac943da1a2981e7488f74b0d4259fbb43f (diff) |
[SCSI] qla2xxx: Remove a dead assignment in qla24xx_build_scsi_crc_2_iocbs().
Since the value of cur_seg is not used and since scsi_prot_sglist()
has no side effects it is safe to remove the statement
"cur_seg = scsi_port_sglist(cmd)". Detected by Coverity.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_iocb.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 9de372f00d4a..42ef481db942 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c | |||
@@ -1189,7 +1189,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct cmd_type_crc_2 *cmd_pkt, | |||
1189 | uint32_t *cur_dsd, *fcp_dl; | 1189 | uint32_t *cur_dsd, *fcp_dl; |
1190 | scsi_qla_host_t *vha; | 1190 | scsi_qla_host_t *vha; |
1191 | struct scsi_cmnd *cmd; | 1191 | struct scsi_cmnd *cmd; |
1192 | struct scatterlist *cur_seg; | ||
1193 | int sgc; | 1192 | int sgc; |
1194 | uint32_t total_bytes = 0; | 1193 | uint32_t total_bytes = 0; |
1195 | uint32_t data_bytes; | 1194 | uint32_t data_bytes; |
@@ -1396,7 +1395,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct cmd_type_crc_2 *cmd_pkt, | |||
1396 | 1395 | ||
1397 | if (bundling && tot_prot_dsds) { | 1396 | if (bundling && tot_prot_dsds) { |
1398 | /* Walks dif segments */ | 1397 | /* Walks dif segments */ |
1399 | cur_seg = scsi_prot_sglist(cmd); | ||
1400 | cmd_pkt->control_flags |= | 1398 | cmd_pkt->control_flags |= |
1401 | __constant_cpu_to_le16(CF_DIF_SEG_DESCR_ENABLE); | 1399 | __constant_cpu_to_le16(CF_DIF_SEG_DESCR_ENABLE); |
1402 | cur_dsd = (uint32_t *) &crc_ctx_pkt->u.bundling.dif_address; | 1400 | cur_dsd = (uint32_t *) &crc_ctx_pkt->u.bundling.dif_address; |