aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/qla2xxx/tcm_qla2xxx.c
diff options
context:
space:
mode:
authorJoern Engel <joern@logfs.org>2013-07-03 11:22:17 -0400
committerNicholas Bellinger <nab@linux-iscsi.org>2013-07-07 21:36:53 -0400
commitb79fafac70fc9bbe640b8193ed772eb850efdfe6 (patch)
treeb99c39999610a4371563ec179d3b2e10a04c2df0 /drivers/scsi/qla2xxx/tcm_qla2xxx.c
parent11fee8a751670cf6d60b1912e2e9cb1c7e392842 (diff)
target: make queue_tm_rsp() return void
The return value wasn't checked by any of the callers. Assuming this is correct behaviour, we can simplify some code by not bothering to generate it. nab: Add srpt_queue_data_in() + srpt_queue_tm_rsp() nops around srpt_queue_response() void return Signed-off-by: Joern Engel <joern@logfs.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/scsi/qla2xxx/tcm_qla2xxx.c')
-rw-r--r--drivers/scsi/qla2xxx/tcm_qla2xxx.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index bb7eb909f0b1..75caa39b807d 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -699,7 +699,7 @@ static int tcm_qla2xxx_queue_status(struct se_cmd *se_cmd)
699 return qlt_xmit_response(cmd, xmit_type, se_cmd->scsi_status); 699 return qlt_xmit_response(cmd, xmit_type, se_cmd->scsi_status);
700} 700}
701 701
702static int tcm_qla2xxx_queue_tm_rsp(struct se_cmd *se_cmd) 702static void tcm_qla2xxx_queue_tm_rsp(struct se_cmd *se_cmd)
703{ 703{
704 struct se_tmr_req *se_tmr = se_cmd->se_tmr_req; 704 struct se_tmr_req *se_tmr = se_cmd->se_tmr_req;
705 struct qla_tgt_mgmt_cmd *mcmd = container_of(se_cmd, 705 struct qla_tgt_mgmt_cmd *mcmd = container_of(se_cmd,
@@ -731,8 +731,6 @@ static int tcm_qla2xxx_queue_tm_rsp(struct se_cmd *se_cmd)
731 * CTIO response packet. 731 * CTIO response packet.
732 */ 732 */
733 qlt_xmit_tm_rsp(mcmd); 733 qlt_xmit_tm_rsp(mcmd);
734
735 return 0;
736} 734}
737 735
738/* Local pointer to allocated TCM configfs fabric module */ 736/* Local pointer to allocated TCM configfs fabric module */