mpt3sas: delay scsi_add_host call to work with scsi-mq

In _scsih_probe, delay the call to scsi_add_host until the host has been
fully set up.

Otherwise, the default .can_queue value of 1 causes scsi-mq to set the block
layer request queue size to its minimum size, resulting in awful performance.

In _scsih_probe error handling, call mpt3sas_base_detach rather than
scsi_remove_host to properly clean up in reverse order.

In _scsih_remove, call scsi_remove_host earlier to clean up in reverse order.

Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@avagotech.com>
Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

2 files changed, 13 insertions, 15 deletions

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index c608a616941a..93ce2b2baa41 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -266,7 +266,7 @@ mpt3sas_base_stop_watchdog(struct MPT3SAS_ADAPTER *ioc)
         ioc->fault_reset_work_q = NULL;
         spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
         if (wq) {
-                if (!cancel_delayed_work(&ioc->fault_reset_work))
+                if (!cancel_delayed_work_sync(&ioc->fault_reset_work))
                         flush_workqueue(wq);
                 destroy_workqueue(wq);
         }
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 57020d528035..7cf48c5c15a7 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -2581,11 +2581,10 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER *ioc)
                 return;
 
         list_for_each_entry_safe(fw_event, next, &ioc->fw_event_list, list) {
-                if (cancel_delayed_work(&fw_event->delayed_work)) {
+                if (cancel_delayed_work_sync(&fw_event->delayed_work)) {
                         _scsih_fw_event_free(ioc, fw_event);
                         continue;
                 }
-                fw_event->cancel_pending_work = 1;
         }
 }
 
@@ -7039,7 +7038,7 @@ static void
 _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event)
 {
         /* the queue is being flushed so ignore this event */
-        if (ioc->remove_host || fw_event->cancel_pending_work ||
+        if (ioc->remove_host ||
             ioc->pci_error_recovery) {
                 _scsih_fw_event_free(ioc, fw_event);
                 return;
@@ -7439,9 +7438,9 @@ static void _scsih_remove(struct pci_dev *pdev)
         }
 
         sas_remove_host(shost);
+        scsi_remove_host(shost);
         mpt3sas_base_detach(ioc);
         list_del(&ioc->list);
-        scsi_remove_host(shost);
         scsi_host_put(shost);
 }
 
@@ -7809,13 +7808,6 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                 }
         }
 
-        if ((scsi_add_host(shost, &pdev->dev))) {
-                pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n",
-                    ioc->name, __FILE__, __LINE__, __func__);
-                list_del(&ioc->list);
-                goto out_add_shost_fail;
-        }
-
         /* register EEDP capabilities with SCSI layer */
         if (prot_mask > 0)
                 scsi_host_set_prot(shost, prot_mask);
@@ -7843,15 +7835,21 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                     ioc->name, __FILE__, __LINE__, __func__);
                 goto out_attach_fail;
         }
+        if ((scsi_add_host(shost, &pdev->dev))) {
+                pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n",
+                    ioc->name, __FILE__, __LINE__, __func__);
+                list_del(&ioc->list);
+                goto out_add_shost_fail;
+        }
+
         scsi_scan_host(shost);
         return 0;
-
+out_add_shost_fail:
+        mpt3sas_base_detach(ioc);
  out_attach_fail:
         destroy_workqueue(ioc->firmware_event_thread);
  out_thread_fail:
         list_del(&ioc->list);
-        scsi_remove_host(shost);
- out_add_shost_fail:
         scsi_host_put(shost);
         return -ENODEV;
 }