diff options
author | Stephen Boyd <sboyd@codeaurora.org> | 2011-05-12 19:50:06 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2011-06-29 11:40:35 -0400 |
commit | b11d48e898de3cbe290051a31a4399e5ba40246b (patch) | |
tree | 0096104b0672ceeef289e9ec7f2e9c20672229c4 /drivers/scsi/lpfc | |
parent | 0d72c6fcb5cd215eeab824fac216ea42c5b574aa (diff) |
[SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning
Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
warning:
In file included from arch/x86/include/asm/uaccess.h:573,
from include/linux/uaccess.h:5,
from include/linux/highmem.h:7,
from include/linux/pagemap.h:10,
from include/linux/blkdev.h:12,
from drivers/scsi/lpfc/lpfc_debugfs.c:21:
In function 'copy_from_user':
arch/x86/include/asm/uaccess_64.h:65:
warning: call to 'copy_from_user_overflow' declared with
attribute warning: copy_from_user() buffer size is not provably
correct
presumably due to buf_size being signed causing GCC to fail to
see that buf_size can't become negative.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/lpfc')
-rw-r--r-- | drivers/scsi/lpfc/lpfc_debugfs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index ffe82d169b40..30b25c5fdd7e 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c | |||
@@ -1147,7 +1147,8 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, | |||
1147 | { | 1147 | { |
1148 | char mybuf[64]; | 1148 | char mybuf[64]; |
1149 | char *pbuf, *step_str; | 1149 | char *pbuf, *step_str; |
1150 | int bsize, i; | 1150 | int i; |
1151 | size_t bsize; | ||
1151 | 1152 | ||
1152 | /* Protect copy from user */ | 1153 | /* Protect copy from user */ |
1153 | if (!access_ok(VERIFY_READ, buf, nbytes)) | 1154 | if (!access_ok(VERIFY_READ, buf, nbytes)) |