diff options
| author | Daniel Borkmann <dborkman@redhat.com> | 2014-09-03 12:56:20 -0400 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-09-16 12:10:07 -0400 |
| commit | a7901acc4ac0f853d9aff284ff96e4a56ff74aa8 (patch) | |
| tree | 12848e7b3d1cb6e8e03e7521973ca6f94b253edd /drivers/scsi/lpfc | |
| parent | 0d4aec132d8ad6303981db08a52d64b0dbe59e97 (diff) | |
lpfc: do not feed jiffies as random seed from lpfc driver
In prandom we have already reseeding mechanisms that trigger
periodically from a much better entropy source than just
feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec()
[what a function name 8-)]. Therefore, just remove this.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Reviewed-by: James Smart <james.smart@emulex.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/lpfc')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_hbadisc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 667d124e3608..859fffa739d8 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c | |||
| @@ -2147,7 +2147,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) | |||
| 2147 | uint16_t fcf_index, next_fcf_index; | 2147 | uint16_t fcf_index, next_fcf_index; |
| 2148 | struct lpfc_fcf_rec *fcf_rec = NULL; | 2148 | struct lpfc_fcf_rec *fcf_rec = NULL; |
| 2149 | uint16_t vlan_id; | 2149 | uint16_t vlan_id; |
| 2150 | uint32_t seed; | ||
| 2151 | bool select_new_fcf; | 2150 | bool select_new_fcf; |
| 2152 | int rc; | 2151 | int rc; |
| 2153 | 2152 | ||
| @@ -2384,9 +2383,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) | |||
| 2384 | phba->fcf.fcf_flag |= FCF_AVAILABLE; | 2383 | phba->fcf.fcf_flag |= FCF_AVAILABLE; |
| 2385 | /* Setup initial running random FCF selection count */ | 2384 | /* Setup initial running random FCF selection count */ |
| 2386 | phba->fcf.eligible_fcf_cnt = 1; | 2385 | phba->fcf.eligible_fcf_cnt = 1; |
| 2387 | /* Seeding the random number generator for random selection */ | ||
| 2388 | seed = (uint32_t)(0xFFFFFFFF & jiffies); | ||
| 2389 | prandom_seed(seed); | ||
| 2390 | } | 2386 | } |
| 2391 | spin_unlock_irq(&phba->hbalock); | 2387 | spin_unlock_irq(&phba->hbalock); |
| 2392 | goto read_next_fcf; | 2388 | goto read_next_fcf; |
