[SCSI] lpfc 8.2.6 : Multiple discovery fixes

Multiple Discovery Fixes:
- Fix race on discovery due to link events coinciding with vport_delete.
- Use NLP_FABRIC state to filter out switch-based pseudo initiators that
   reuse the same WWNs.
- Correct erroneous setting of DID=0 in lpfc_matchdid()
- Correct extra reference count that was in the lookup path for the
  remoteid from an unsolicited ELS.
- Correct double-free bug in els abort path.
- Correct FDMI server discovery logic for switch that return a WWN of 0.
- Fix bugs in ndlp mgmt when a node changes address
- Correct bug that did not delete RSCNs for vports upon link transitions
- Fix "0216 Link event during NS query" error which pops up when vports
  are swapped to different switch ports.
- Add sanity checks on ndlp structures
- Fix devloss log message to dump WWN correctly
- Hold off mgmt commands that were interferring with discovery mailbox cmds
- Remove unnecessary FC_ESTABLISH_LINK logic.
- Correct some race conditions in the worker thread, resulting in devloss:
  - Clear the work_port_events field before handling the work port events
  - Clear the deferred ring event before handling a deferred ring event
  - Hold the hba lock when waking up the work thread
  - Send an acc for the rscn even when we aren't going to handle it
- Fix locking behavior that was not properly protecting the ACTIVE flag,
  thus allowing mailbox command order to shift.

Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

1 files changed, 23 insertions, 17 deletions

diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
index d513813f6697..d08c4c890744 100644
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
@@ -451,7 +451,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
                         spin_unlock_irq(shost->host_lock);
 
                         if ((ndlp->nlp_flag & NLP_ADISC_SND) &&
-                                (vport->num_disc_nodes)) {
+                            (vport->num_disc_nodes)) {
                                 /* Check to see if there are more
                                  * ADISCs to be sent
                                  */
@@ -469,20 +469,23 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
                                         lpfc_end_rscn(vport);
                                 }
                         }
-                        else if (vport->num_disc_nodes) {
-                                /* Check to see if there are more
-                                 * PLOGIs to be sent
-                                 */
-                                lpfc_more_plogi(vport);
-
-                                if (vport->num_disc_nodes == 0) {
-                                        spin_lock_irq(shost->host_lock);
-                                        vport->fc_flag &= ~FC_NDISC_ACTIVE;
-                                        spin_unlock_irq(shost->host_lock);
-                                        lpfc_can_disctmo(vport);
-                                        lpfc_end_rscn(vport);
-                                }
-                        }
+                }
+        } else if ((ndlp->nlp_state == NLP_STE_PLOGI_ISSUE) &&
+                   (ndlp->nlp_flag & NLP_NPR_2B_DISC) &&
+                   (vport->num_disc_nodes)) {
+                spin_lock_irq(shost->host_lock);
+                ndlp->nlp_flag &= ~NLP_NPR_2B_DISC;
+                spin_unlock_irq(shost->host_lock);
+                /* Check to see if there are more
+                 * PLOGIs to be sent
+                 */
+                lpfc_more_plogi(vport);
+                if (vport->num_disc_nodes == 0) {
+                        spin_lock_irq(shost->host_lock);
+                        vport->fc_flag &= ~FC_NDISC_ACTIVE;
+                        spin_unlock_irq(shost->host_lock);
+                        lpfc_can_disctmo(vport);
+                        lpfc_end_rscn(vport);
                 }
         }
 
@@ -869,8 +872,11 @@ lpfc_cmpl_plogi_plogi_issue(struct lpfc_vport *vport,
 
         lp = (uint32_t *) prsp->virt;
         sp = (struct serv_parm *) ((uint8_t *) lp + sizeof (uint32_t));
-        if (wwn_to_u64(sp->portName.u.wwn) == 0 ||
-            wwn_to_u64(sp->nodeName.u.wwn) == 0) {
+
+        /* Some switches have FDMI servers returning 0 for WWN */
+        if ((ndlp->nlp_DID != FDMI_DID) &&
+                (wwn_to_u64(sp->portName.u.wwn) == 0 ||
+                wwn_to_u64(sp->nodeName.u.wwn) == 0)) {
                 lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
                                  "0142 PLOGI RSP: Invalid WWN.\n");
                 goto out;