[SCSI] lpfc 8.3.25: Enhancements to Debug infrastructure

Enhancements to Debug infrastructure

- debugfs additions for new hardware.
- Correct stack overflow in lpfc_debugfs_dumpHBASlim_data()
- Correct warning on uninitialized reg_val in lpfc_idiag_drbacc_write()
- Separated the iDiag command for capturing mailbox commands for generic
  issue mailbox command entry point and for BSG multi-buffer handling.
- Added capturing dumping capabiliy of mailbox command and external buffer
  for the completion of the mailbox command so that the outcome can be
  examined.
- Changed all the iDiag command structure data array indexing introduced so
  far with properly defined macros.
- Added SLI4 device PCI BAR memory mapped register read/browse, write-by-
  value, set-bit, and clear-bit methods for both interface type 0 and
  interface type 2.
- Corrected warnings on mbxstatus being uninitialized in error paths in
  lpfc_bsg.c

Signed-off-by: Alex Iannicelli <alex.iannicelli@emulex.com>
Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

1 files changed, 35 insertions, 2 deletions

diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index f46378fb802c..6760c69f5253 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -42,6 +42,7 @@
 #include "lpfc.h"
 #include "lpfc_logmsg.h"
 #include "lpfc_crtn.h"
+#include "lpfc_debugfs.h"
 #include "lpfc_vport.h"
 #include "lpfc_version.h"
 
@@ -1566,7 +1567,7 @@ lpfc_sli3_bsg_diag_loopback_mode(struct lpfc_hba *phba, struct fc_bsg_job *job)
         uint32_t link_flags;
         uint32_t timeout;
         LPFC_MBOXQ_t *pmboxq;
-        int mbxstatus;
+        int mbxstatus = MBX_SUCCESS;
         int i = 0;
         int rc = 0;
 
@@ -1740,7 +1741,7 @@ lpfc_sli4_bsg_diag_loopback_mode(struct lpfc_hba *phba, struct fc_bsg_job *job)
         uint32_t link_flags, timeout, req_len, alloc_len;
         struct lpfc_mbx_set_link_diag_loopback *link_diag_loopback;
         LPFC_MBOXQ_t *pmboxq = NULL;
-        int mbxstatus, i, rc = 0;
+        int mbxstatus = MBX_SUCCESS, i, rc = 0;
 
         /* no data to return just the return code */
         job->reply->reply_payload_rcv_len = 0;
@@ -3177,6 +3178,11 @@ lpfc_bsg_issue_mbox_ext_handle_job(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq)
                                 "(x%x/x%x) complete bsg job done, bsize:%d\n",
                                 phba->mbox_ext_buf_ctx.nembType,
                                 phba->mbox_ext_buf_ctx.mboxType, size);
+                lpfc_idiag_mbxacc_dump_bsg_mbox(phba,
+                                        phba->mbox_ext_buf_ctx.nembType,
+                                        phba->mbox_ext_buf_ctx.mboxType,
+                                        dma_ebuf, sta_pos_addr,
+                                        phba->mbox_ext_buf_ctx.mbx_dmabuf, 0);
         } else
                 spin_unlock_irqrestore(&phba->ct_ev_lock, flags);
 
@@ -3429,6 +3435,10 @@ lpfc_bsg_sli_cfg_read_cmd_ext(struct lpfc_hba *phba, struct fc_bsg_job *job,
                                 "ext_buf_cnt:%d\n", ext_buf_cnt);
         }
 
+        /* before dma descriptor setup */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, nemb_tp, mbox_rd, dma_mbox,
+                                        sta_pre_addr, dmabuf, ext_buf_cnt);
+
         /* reject non-embedded mailbox command with none external buffer */
         if (ext_buf_cnt == 0) {
                 rc = -EPERM;
@@ -3476,6 +3486,10 @@ lpfc_bsg_sli_cfg_read_cmd_ext(struct lpfc_hba *phba, struct fc_bsg_job *job,
                 }
         }
 
+        /* after dma descriptor setup */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, nemb_tp, mbox_rd, dma_mbox,
+                                        sta_pos_addr, dmabuf, ext_buf_cnt);
+
         /* construct base driver mbox command */
         pmb = &pmboxq->u.mb;
         pmbx = (uint8_t *)dmabuf->virt;
@@ -3590,12 +3604,20 @@ lpfc_bsg_sli_cfg_write_cmd_ext(struct lpfc_hba *phba, struct fc_bsg_job *job,
                                 "ext_buf_cnt:%d\n", ext_buf_cnt);
         }
 
+        /* before dma buffer descriptor setup */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, nemb_tp, mbox_wr, dma_mbox,
+                                        sta_pre_addr, dmabuf, ext_buf_cnt);
+
         if (ext_buf_cnt == 0)
                 return -EPERM;
 
         /* for the first external buffer */
         lpfc_bsg_sli_cfg_dma_desc_setup(phba, nemb_tp, 0, dmabuf, dmabuf);
 
+        /* after dma descriptor setup */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, nemb_tp, mbox_wr, dma_mbox,
+                                        sta_pos_addr, dmabuf, ext_buf_cnt);
+
         /* log for looking forward */
         for (i = 1; i < ext_buf_cnt; i++) {
                 if (nemb_tp == nemb_mse)
@@ -3844,6 +3866,12 @@ lpfc_bsg_read_ebuf_get(struct lpfc_hba *phba, struct fc_bsg_job *job)
         dmabuf = list_first_entry(&phba->mbox_ext_buf_ctx.ext_dmabuf_list,
                                   struct lpfc_dmabuf, list);
         list_del_init(&dmabuf->list);
+
+        /* after dma buffer descriptor setup */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, phba->mbox_ext_buf_ctx.nembType,
+                                        mbox_rd, dma_ebuf, sta_pos_addr,
+                                        dmabuf, index);
+
         pbuf = (uint8_t *)dmabuf->virt;
         job->reply->reply_payload_rcv_len =
                 sg_copy_from_buffer(job->reply_payload.sg_list,
@@ -3926,6 +3954,11 @@ lpfc_bsg_write_ebuf_set(struct lpfc_hba *phba, struct fc_bsg_job *job,
                                         dmabuf);
         list_add_tail(&dmabuf->list, &phba->mbox_ext_buf_ctx.ext_dmabuf_list);
 
+        /* after write dma buffer */
+        lpfc_idiag_mbxacc_dump_bsg_mbox(phba, phba->mbox_ext_buf_ctx.nembType,
+                                        mbox_wr, dma_ebuf, sta_pos_addr,
+                                        dmabuf, index);
+
         if (phba->mbox_ext_buf_ctx.seqNum == phba->mbox_ext_buf_ctx.numBuf) {
                 lpfc_printf_log(phba, KERN_INFO, LOG_LIBDFC,
                                 "2968 SLI_CONFIG ext-buffer wr all %d "