diff options
author | Dan Williams <dan.j.williams@intel.com> | 2011-03-04 14:51:43 -0500 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2011-07-03 06:55:29 -0400 |
commit | 3a97eec6d7876c541950e23811efd40e0bcd04a0 (patch) | |
tree | 543e52abd6d41df724374fbdd6fe852ac611ca50 /drivers/scsi/isci/task.c | |
parent | b329aff107543c3c4db26c1572405034c3baf906 (diff) |
isci: remove sci_device_handle
It belies the fact that isci_remote_device and scic_sds_remote_device
are one in same object with the same lifetime rules.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/scsi/isci/task.c')
-rw-r--r-- | drivers/scsi/isci/task.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/scsi/isci/task.c b/drivers/scsi/isci/task.c index 232125eab523..c637bbc215c6 100644 --- a/drivers/scsi/isci/task.c +++ b/drivers/scsi/isci/task.c | |||
@@ -285,7 +285,7 @@ static enum sci_status isci_task_request_build( | |||
285 | "%s: isci_tmf = %p\n", __func__, isci_tmf); | 285 | "%s: isci_tmf = %p\n", __func__, isci_tmf); |
286 | 286 | ||
287 | isci_device = isci_tmf->device; | 287 | isci_device = isci_tmf->device; |
288 | sci_device = isci_device->sci_device_handle; | 288 | sci_device = to_sci_dev(isci_device); |
289 | 289 | ||
290 | /* do common allocation and init of request object. */ | 290 | /* do common allocation and init of request object. */ |
291 | status = isci_request_alloc_tmf( | 291 | status = isci_request_alloc_tmf( |
@@ -395,7 +395,7 @@ static void isci_tmf_timeout_cb(void *tmf_request_arg) | |||
395 | /* Terminate the TMF transmit request. */ | 395 | /* Terminate the TMF transmit request. */ |
396 | status = scic_controller_terminate_request( | 396 | status = scic_controller_terminate_request( |
397 | request->isci_host->core_controller, | 397 | request->isci_host->core_controller, |
398 | request->isci_device->sci_device_handle, | 398 | to_sci_dev(request->isci_device), |
399 | request->sci_request_handle | 399 | request->sci_request_handle |
400 | ); | 400 | ); |
401 | 401 | ||
@@ -456,7 +456,7 @@ int isci_task_execute_tmf( | |||
456 | "%s: isci_device = %p\n", | 456 | "%s: isci_device = %p\n", |
457 | __func__, isci_device); | 457 | __func__, isci_device); |
458 | 458 | ||
459 | sci_device = isci_device->sci_device_handle; | 459 | sci_device = to_sci_dev(isci_device); |
460 | 460 | ||
461 | /* Assign the pointer to the TMF's completion kernel wait structure. */ | 461 | /* Assign the pointer to the TMF's completion kernel wait structure. */ |
462 | tmf->complete = &completion; | 462 | tmf->complete = &completion; |
@@ -728,7 +728,7 @@ static void isci_terminate_request_core( | |||
728 | was_terminated = true; | 728 | was_terminated = true; |
729 | status = scic_controller_terminate_request( | 729 | status = scic_controller_terminate_request( |
730 | isci_host->core_controller, | 730 | isci_host->core_controller, |
731 | isci_device->sci_device_handle, | 731 | to_sci_dev(isci_device), |
732 | isci_request->sci_request_handle | 732 | isci_request->sci_request_handle |
733 | ); | 733 | ); |
734 | } | 734 | } |
@@ -1469,7 +1469,7 @@ void isci_task_request_complete( | |||
1469 | 1469 | ||
1470 | scic_controller_complete_task( | 1470 | scic_controller_complete_task( |
1471 | isci_host->core_controller, | 1471 | isci_host->core_controller, |
1472 | isci_device->sci_device_handle, | 1472 | to_sci_dev(isci_device), |
1473 | request->sci_request_handle | 1473 | request->sci_request_handle |
1474 | ); | 1474 | ); |
1475 | /* NULL the request handle to make sure it cannot be terminated | 1475 | /* NULL the request handle to make sure it cannot be terminated |
@@ -1612,7 +1612,7 @@ int isci_bus_reset_handler(struct scsi_cmnd *cmd) | |||
1612 | if (isci_host != NULL) | 1612 | if (isci_host != NULL) |
1613 | spin_lock_irqsave(&isci_host->scic_lock, flags); | 1613 | spin_lock_irqsave(&isci_host->scic_lock, flags); |
1614 | 1614 | ||
1615 | status = scic_remote_device_reset(isci_dev->sci_device_handle); | 1615 | status = scic_remote_device_reset(to_sci_dev(isci_dev)); |
1616 | if (status != SCI_SUCCESS) { | 1616 | if (status != SCI_SUCCESS) { |
1617 | 1617 | ||
1618 | if (isci_host != NULL) | 1618 | if (isci_host != NULL) |
@@ -1654,8 +1654,7 @@ int isci_bus_reset_handler(struct scsi_cmnd *cmd) | |||
1654 | 1654 | ||
1655 | if (isci_host != NULL) | 1655 | if (isci_host != NULL) |
1656 | spin_lock_irqsave(&isci_host->scic_lock, flags); | 1656 | spin_lock_irqsave(&isci_host->scic_lock, flags); |
1657 | status | 1657 | status = scic_remote_device_reset_complete(to_sci_dev(isci_dev)); |
1658 | = scic_remote_device_reset_complete(isci_dev->sci_device_handle); | ||
1659 | 1658 | ||
1660 | if (isci_host != NULL) | 1659 | if (isci_host != NULL) |
1661 | spin_unlock_irqrestore(&isci_host->scic_lock, flags); | 1660 | spin_unlock_irqrestore(&isci_host->scic_lock, flags); |