scsi: provide a generic change_queue_type method

Most drivers use exactly the same implementation, so provide it as a
library function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>

1 files changed, 3 insertions, 17 deletions

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 2a9578c116b7..3d689f6023e9 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -4364,24 +4364,10 @@ static int ipr_change_queue_type(struct scsi_device *sdev, int tag_type)
 
         spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
         res = (struct ipr_resource_entry *)sdev->hostdata;
-
-        if (res) {
-                if (ipr_is_gscsi(res) && sdev->tagged_supported) {
-                        /*
-                         * We don't bother quiescing the device here since the
-                         * adapter firmware does it for us.
-                         */
-                        scsi_set_tag_type(sdev, tag_type);
-
-                        if (tag_type)
-                                scsi_activate_tcq(sdev, sdev->queue_depth);
-                        else
-                                scsi_deactivate_tcq(sdev, sdev->queue_depth);
-                } else
-                        tag_type = 0;
-        } else
+        if (res && ipr_is_gscsi(res))
+                tag_type = scsi_change_queue_type(sdev, tag_type);
+        else
                 tag_type = 0;
-
         spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
         return tag_type;
 }