diff options
author | Stephen Cameron <stephenmcameron@gmail.com> | 2015-01-23 17:43:14 -0500 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2015-02-02 12:57:40 -0500 |
commit | 7acf570ce51a5ebee55ef72e77916afdb4a351a7 (patch) | |
tree | bc787b4b0390c5369bc95718165df8b8b8233a17 /drivers/scsi/hpsa.h | |
parent | f2405db8b4605732c8f0224c33b9d206e37b68c5 (diff) |
hpsa: do not request device rescan on every ioaccel path error
The original reasoning behind doing this was faulty. An error
of some sort would be encountered, accelerated i/o would be
disabled for that logical drive, the command would be kicked
back out to the SCSI midlayer for a retry, and since i/o accelerator
mode was disabled, it would get retried down the RAID path.
However, something needs to turn ioaccellerator mode back on,
and this rescan request was what did that. However, it was racy,
and extremely bad for performance to rescan all devices, so,
don't do that.
Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/hpsa.h')
-rw-r--r-- | drivers/scsi/hpsa.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index e7d7eaa864d1..06a3e812ec38 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h | |||
@@ -235,7 +235,6 @@ struct ctlr_info { | |||
235 | spinlock_t offline_device_lock; | 235 | spinlock_t offline_device_lock; |
236 | struct list_head offline_device_list; | 236 | struct list_head offline_device_list; |
237 | int acciopath_status; | 237 | int acciopath_status; |
238 | int drv_req_rescan; /* flag for driver to request rescan event */ | ||
239 | int raid_offload_debug; | 238 | int raid_offload_debug; |
240 | }; | 239 | }; |
241 | 240 | ||