Merge branch 'master' [vanilla Linus master] into libata-dev.git/upstream

Two bits were appended to the end of the bitfield
list in struct scsi_device.  Resolve that conflict
by including both bits.

Conflicts:
	include/scsi/scsi_device.h

4 files changed, 32 insertions, 31 deletions

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index fe30b1b65e1d..078d262ac7cc 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1529,7 +1529,7 @@ static int fcoe_rcv(struct sk_buff *skb, struct net_device *netdev,
 
         return 0;
 err:
-        per_cpu_ptr(lport->dev_stats, get_cpu())->ErrorFrames++;
+        per_cpu_ptr(lport->stats, get_cpu())->ErrorFrames++;
         put_cpu();
 err2:
         kfree_skb(skb);
@@ -1569,7 +1569,7 @@ static int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp)
         struct ethhdr *eh;
         struct fcoe_crc_eof *cp;
         struct sk_buff *skb;
-        struct fcoe_dev_stats *stats;
+        struct fc_stats *stats;
         struct fc_frame_header *fh;
         unsigned int hlen;              /* header length implies the version */
         unsigned int tlen;              /* trailer length */
@@ -1680,7 +1680,7 @@ static int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp)
                 skb_shinfo(skb)->gso_size = 0;
         }
         /* update tx stats: regardless if LLD fails */
-        stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+        stats = per_cpu_ptr(lport->stats, get_cpu());
         stats->TxFrames++;
         stats->TxWords += wlen;
         put_cpu();
@@ -1714,7 +1714,7 @@ static inline int fcoe_filter_frames(struct fc_lport *lport,
         struct fcoe_interface *fcoe;
         struct fc_frame_header *fh;
         struct sk_buff *skb = (struct sk_buff *)fp;
-        struct fcoe_dev_stats *stats;
+        struct fc_stats *stats;
 
         /*
          * We only check CRC if no offload is available and if it is
@@ -1745,7 +1745,7 @@ static inline int fcoe_filter_frames(struct fc_lport *lport,
                 return 0;
         }
 
-        stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+        stats = per_cpu_ptr(lport->stats, get_cpu());
         stats->InvalidCRCCount++;
         if (stats->InvalidCRCCount < 5)
                 printk(KERN_WARNING "fcoe: dropping frame with CRC error\n");
@@ -1762,7 +1762,7 @@ static void fcoe_recv_frame(struct sk_buff *skb)
         u32 fr_len;
         struct fc_lport *lport;
         struct fcoe_rcv_info *fr;
-        struct fcoe_dev_stats *stats;
+        struct fc_stats *stats;
         struct fcoe_crc_eof crc_eof;
         struct fc_frame *fp;
         struct fcoe_port *port;
@@ -1793,7 +1793,7 @@ static void fcoe_recv_frame(struct sk_buff *skb)
          */
         hp = (struct fcoe_hdr *) skb_network_header(skb);
 
-        stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+        stats = per_cpu_ptr(lport->stats, get_cpu());
         if (unlikely(FC_FCOE_DECAPS_VER(hp) != FC_FCOE_VER)) {
                 if (stats->ErrorFrames < 5)
                         printk(KERN_WARNING "fcoe: FCoE version "
@@ -1851,23 +1851,25 @@ static int fcoe_percpu_receive_thread(void *arg)
 
         set_user_nice(current, -20);
 
+retry:
         while (!kthread_should_stop()) {
 
                 spin_lock_bh(&p->fcoe_rx_list.lock);
                 skb_queue_splice_init(&p->fcoe_rx_list, &tmp);
-                spin_unlock_bh(&p->fcoe_rx_list.lock);
-
-                while ((skb = __skb_dequeue(&tmp)) != NULL)
-                        fcoe_recv_frame(skb);
 
-                spin_lock_bh(&p->fcoe_rx_list.lock);
-                if (!skb_queue_len(&p->fcoe_rx_list)) {
+                if (!skb_queue_len(&tmp)) {
                         set_current_state(TASK_INTERRUPTIBLE);
                         spin_unlock_bh(&p->fcoe_rx_list.lock);
                         schedule();
                         set_current_state(TASK_RUNNING);
-                } else
-                        spin_unlock_bh(&p->fcoe_rx_list.lock);
+                        goto retry;
+                }
+
+                spin_unlock_bh(&p->fcoe_rx_list.lock);
+
+                while ((skb = __skb_dequeue(&tmp)) != NULL)
+                        fcoe_recv_frame(skb);
+
         }
         return 0;
 }
@@ -1970,7 +1972,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
         struct fcoe_ctlr *ctlr;
         struct fcoe_interface *fcoe;
         struct fcoe_port *port;
-        struct fcoe_dev_stats *stats;
+        struct fc_stats *stats;
         u32 link_possible = 1;
         u32 mfs;
         int rc = NOTIFY_OK;
@@ -2024,7 +2026,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
         if (link_possible && !fcoe_link_ok(lport))
                 fcoe_ctlr_link_up(ctlr);
         else if (fcoe_ctlr_link_down(ctlr)) {
-                stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+                stats = per_cpu_ptr(lport->stats, get_cpu());
                 stats->LinkFailureCount++;
                 put_cpu();
                 fcoe_clean_pending_queue(lport);
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index d68d57241ee6..2ebe03a4b51d 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -788,11 +788,11 @@ static unsigned long fcoe_ctlr_age_fcfs(struct fcoe_ctlr *fip)
         unsigned long deadline;
         unsigned long sel_time = 0;
         struct list_head del_list;
-        struct fcoe_dev_stats *stats;
+        struct fc_stats *stats;
 
         INIT_LIST_HEAD(&del_list);
 
-        stats = per_cpu_ptr(fip->lp->dev_stats, get_cpu());
+        stats = per_cpu_ptr(fip->lp->stats, get_cpu());
 
         list_for_each_entry_safe(fcf, next, &fip->fcfs, list) {
                 deadline = fcf->time + fcf->fka_period + fcf->fka_period / 2;
@@ -1104,8 +1104,8 @@ static void fcoe_ctlr_recv_els(struct fcoe_ctlr *fip, struct sk_buff *skb)
         struct fc_frame_header *fh = NULL;
         struct fip_desc *desc;
         struct fip_encaps *els;
-        struct fcoe_dev_stats *stats;
         struct fcoe_fcf *sel;
+        struct fc_stats *stats;
         enum fip_desc_type els_dtype = 0;
         u8 els_op;
         u8 sub;
@@ -1249,7 +1249,7 @@ static void fcoe_ctlr_recv_els(struct fcoe_ctlr *fip, struct sk_buff *skb)
         fr_dev(fp) = lport;
         fr_encaps(fp) = els_dtype;
 
-        stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+        stats = per_cpu_ptr(lport->stats, get_cpu());
         stats->RxFrames++;
         stats->RxWords += skb->len / FIP_BPW;
         put_cpu();
@@ -1353,7 +1353,7 @@ static void fcoe_ctlr_recv_clr_vlink(struct fcoe_ctlr *fip,
                                                       ntoh24(vp->fd_fc_id));
                         if (vn_port && (vn_port == lport)) {
                                 mutex_lock(&fip->ctlr_mutex);
-                                per_cpu_ptr(lport->dev_stats,
+                                per_cpu_ptr(lport->stats,
                                             get_cpu())->VLinkFailureCount++;
                                 put_cpu();
                                 fcoe_ctlr_reset(fip);
@@ -1383,8 +1383,7 @@ static void fcoe_ctlr_recv_clr_vlink(struct fcoe_ctlr *fip,
                  * followed by physical port
                  */
                 mutex_lock(&fip->ctlr_mutex);
-                per_cpu_ptr(lport->dev_stats,
-                            get_cpu())->VLinkFailureCount++;
+                per_cpu_ptr(lport->stats, get_cpu())->VLinkFailureCount++;
                 put_cpu();
                 fcoe_ctlr_reset(fip);
                 mutex_unlock(&fip->ctlr_mutex);
diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c
index 2bc163198d33..5e751689a089 100644
--- a/drivers/scsi/fcoe/fcoe_sysfs.c
+++ b/drivers/scsi/fcoe/fcoe_sysfs.c
@@ -102,7 +102,7 @@ static int fcoe_str_to_dev_loss(const char *buf, unsigned long *val)
         int ret;
 
         ret = kstrtoul(buf, 0, val);
-        if (ret || *val < 0)
+        if (ret)
                 return -EINVAL;
         /*
          * Check for overflow; dev_loss_tmo is u32
diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index b46f43dced78..ac76d8a042d7 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -89,7 +89,7 @@ void __fcoe_get_lesb(struct fc_lport *lport,
 {
         unsigned int cpu;
         u32 lfc, vlfc, mdac;
-        struct fcoe_dev_stats *devst;
+        struct fc_stats *stats;
         struct fcoe_fc_els_lesb *lesb;
         struct rtnl_link_stats64 temp;
 
@@ -99,10 +99,10 @@ void __fcoe_get_lesb(struct fc_lport *lport,
         lesb = (struct fcoe_fc_els_lesb *)fc_lesb;
         memset(lesb, 0, sizeof(*lesb));
         for_each_possible_cpu(cpu) {
-                devst = per_cpu_ptr(lport->dev_stats, cpu);
-                lfc += devst->LinkFailureCount;
-                vlfc += devst->VLinkFailureCount;
-                mdac += devst->MissDiscAdvCount;
+                stats = per_cpu_ptr(lport->stats, cpu);
+                lfc += stats->LinkFailureCount;
+                vlfc += stats->VLinkFailureCount;
+                mdac += stats->MissDiscAdvCount;
         }
         lesb->lesb_link_fail = htonl(lfc);
         lesb->lesb_vlink_fail = htonl(vlfc);
@@ -502,7 +502,7 @@ static int __init fcoe_transport_init(void)
         return 0;
 }
 
-static int __exit fcoe_transport_exit(void)
+static int fcoe_transport_exit(void)
 {
         struct fcoe_transport *ft;