Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6

* master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (73 commits)
  [SCSI] aic79xx: Add ASC-29320LPE ids to driver
  [SCSI] stex: version update
  [SCSI] stex: change wait loop code
  [SCSI] stex: add new device type support
  [SCSI] stex: update device id info
  [SCSI] stex: adjust default queue length
  [SCSI] stex: add value check in hard reset routine
  [SCSI] stex: fix controller_info command handling
  [SCSI] stex: fix biosparam calculation
  [SCSI] megaraid: fix MMIO casts
  [SCSI] tgt: fix undefined flush_dcache_page() problem
  [SCSI] libsas: better error handling in sas_expander.c
  [SCSI] lpfc 8.1.11 : Change version number to 8.1.11
  [SCSI] lpfc 8.1.11 : Misc Fixes
  [SCSI] lpfc 8.1.11 : Add soft_wwnn sysfs attribute, rename soft_wwn_enable
  [SCSI] lpfc 8.1.11 : Removed decoding of PCI Subsystem Id
  [SCSI] lpfc 8.1.11 : Add MSI (Message Signalled Interrupts) support
  [SCSI] lpfc 8.1.11 : Adjust LOG_FCP logging
  [SCSI] lpfc 8.1.11 : Fix Memory leaks
  [SCSI] lpfc 8.1.11 : Fix lpfc_multi_ring_support
  ...

2 files changed, 112 insertions, 17 deletions

diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index 57c5ba4043f2..42302ef05ee5 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -724,6 +724,15 @@ static void asd_free_queues(struct asd_ha_struct *asd_ha)
 
         list_for_each_safe(pos, n, &pending) {
                 struct asd_ascb *ascb = list_entry(pos, struct asd_ascb, list);
+                /*
+                 * Delete unexpired ascb timers.  This may happen if we issue
+                 * a CONTROL PHY scb to an adapter and rmmod before the scb
+                 * times out.  Apparently we don't wait for the CONTROL PHY
+                 * to complete, so it doesn't matter if we kill the timer.
+                 */
+                del_timer_sync(&ascb->timer);
+                WARN_ON(ascb->scb->header.opcode != CONTROL_PHY);
+
                 list_del_init(pos);
                 ASD_DPRINTK("freeing from pending\n");
                 asd_ascb_free(ascb);
diff --git a/drivers/scsi/aic94xx/aic94xx_scb.c b/drivers/scsi/aic94xx/aic94xx_scb.c
index b15caf1c8fa2..14d5d8c2ee13 100644
--- a/drivers/scsi/aic94xx/aic94xx_scb.c
+++ b/drivers/scsi/aic94xx/aic94xx_scb.c
@@ -25,6 +25,7 @@
  */
 
 #include <linux/pci.h>
+#include <scsi/scsi_host.h>
 
 #include "aic94xx.h"
 #include "aic94xx_reg.h"
@@ -412,6 +413,39 @@ void asd_invalidate_edb(struct asd_ascb *ascb, int edb_id)
         }
 }
 
+/* hard reset a phy later */
+static void do_phy_reset_later(void *data)
+{
+        struct sas_phy *sas_phy = data;
+        int error;
+
+        ASD_DPRINTK("%s: About to hard reset phy %d\n", __FUNCTION__,
+                    sas_phy->identify.phy_identifier);
+        /* Reset device port */
+        error = sas_phy_reset(sas_phy, 1);
+        if (error)
+                ASD_DPRINTK("%s: Hard reset of phy %d failed (%d).\n",
+                            __FUNCTION__, sas_phy->identify.phy_identifier, error);
+}
+
+static void phy_reset_later(struct sas_phy *sas_phy, struct Scsi_Host *shost)
+{
+        INIT_WORK(&sas_phy->reset_work, do_phy_reset_later, sas_phy);
+        queue_work(shost->work_q, &sas_phy->reset_work);
+}
+
+/* start up the ABORT TASK tmf... */
+static void task_kill_later(struct asd_ascb *ascb)
+{
+        struct asd_ha_struct *asd_ha = ascb->ha;
+        struct sas_ha_struct *sas_ha = &asd_ha->sas_ha;
+        struct Scsi_Host *shost = sas_ha->core.shost;
+        struct sas_task *task = ascb->uldd_task;
+
+        INIT_WORK(&task->abort_work, (void (*)(void *))sas_task_abort, task);
+        queue_work(shost->work_q, &task->abort_work);
+}
+
 static void escb_tasklet_complete(struct asd_ascb *ascb,
                                   struct done_list_struct *dl)
 {
@@ -439,6 +473,74 @@ static void escb_tasklet_complete(struct asd_ascb *ascb,
                             ascb->scb->header.opcode);
         }
 
+        /* Catch these before we mask off the sb_opcode bits */
+        switch (sb_opcode) {
+        case REQ_TASK_ABORT: {
+                struct asd_ascb *a, *b;
+                u16 tc_abort;
+
+                tc_abort = *((u16*)(&dl->status_block[1]));
+                tc_abort = le16_to_cpu(tc_abort);
+
+                ASD_DPRINTK("%s: REQ_TASK_ABORT, reason=0x%X\n",
+                            __FUNCTION__, dl->status_block[3]);
+
+                /* Find the pending task and abort it. */
+                list_for_each_entry_safe(a, b, &asd_ha->seq.pend_q, list)
+                        if (a->tc_index == tc_abort) {
+                                task_kill_later(a);
+                                break;
+                        }
+                goto out;
+        }
+        case REQ_DEVICE_RESET: {
+                struct Scsi_Host *shost = sas_ha->core.shost;
+                struct sas_phy *dev_phy;
+                struct asd_ascb *a;
+                u16 conn_handle;
+
+                conn_handle = *((u16*)(&dl->status_block[1]));
+                conn_handle = le16_to_cpu(conn_handle);
+
+                ASD_DPRINTK("%s: REQ_DEVICE_RESET, reason=0x%X\n", __FUNCTION__,
+                            dl->status_block[3]);
+
+                /* Kill all pending tasks and reset the device */
+                dev_phy = NULL;
+                list_for_each_entry(a, &asd_ha->seq.pend_q, list) {
+                        struct sas_task *task;
+                        struct domain_device *dev;
+                        u16 x;
+
+                        task = a->uldd_task;
+                        if (!task)
+                                continue;
+                        dev = task->dev;
+
+                        x = (unsigned long)dev->lldd_dev;
+                        if (x == conn_handle) {
+                                dev_phy = dev->port->phy;
+                                task_kill_later(a);
+                        }
+                }
+
+                /* Reset device port */
+                if (!dev_phy) {
+                        ASD_DPRINTK("%s: No pending commands; can't reset.\n",
+                                    __FUNCTION__);
+                        goto out;
+                }
+                phy_reset_later(dev_phy, shost);
+                goto out;
+        }
+        case SIGNAL_NCQ_ERROR:
+                ASD_DPRINTK("%s: SIGNAL_NCQ_ERROR\n", __FUNCTION__);
+                goto out;
+        case CLEAR_NCQ_ERROR:
+                ASD_DPRINTK("%s: CLEAR_NCQ_ERROR\n", __FUNCTION__);
+                goto out;
+        }
+
         sb_opcode &= ~DL_PHY_MASK;
 
         switch (sb_opcode) {
@@ -469,22 +571,6 @@ static void escb_tasklet_complete(struct asd_ascb *ascb,
                 asd_deform_port(asd_ha, phy);
                 sas_ha->notify_port_event(sas_phy, PORTE_TIMER_EVENT);
                 break;
-        case REQ_TASK_ABORT:
-                ASD_DPRINTK("%s: phy%d: REQ_TASK_ABORT\n", __FUNCTION__,
-                            phy_id);
-                break;
-        case REQ_DEVICE_RESET:
-                ASD_DPRINTK("%s: phy%d: REQ_DEVICE_RESET\n", __FUNCTION__,
-                            phy_id);
-                break;
-        case SIGNAL_NCQ_ERROR:
-                ASD_DPRINTK("%s: phy%d: SIGNAL_NCQ_ERROR\n", __FUNCTION__,
-                            phy_id);
-                break;
-        case CLEAR_NCQ_ERROR:
-                ASD_DPRINTK("%s: phy%d: CLEAR_NCQ_ERROR\n", __FUNCTION__,
-                            phy_id);
-                break;
         default:
                 ASD_DPRINTK("%s: phy%d: unknown event:0x%x\n", __FUNCTION__,
                             phy_id, sb_opcode);
@@ -504,7 +590,7 @@ static void escb_tasklet_complete(struct asd_ascb *ascb,
 
                 break;
         }
-
+out:
         asd_invalidate_edb(ascb, edb);
 }