diff options
author | James Bottomley <James.Bottomley@steeleye.com> | 2005-10-02 16:22:35 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-10-02 16:32:25 -0400 |
commit | 97af50f60ff1202b0dd9ce481d4cf98c6a578bec (patch) | |
tree | 5637b5d7d505869ee5aace5ad6ed33085fc78697 /drivers/scsi/aic7xxx/aic7xxx_osm.c | |
parent | 9e70592fcd87c90e9e98090d66cb79f39d740d4a (diff) |
[SCSI] aic7xxx/aic79xx: fix module removal path not to panic
In these drivers, scsi_remove_host() is called too late, at the point
it is called, the driver has already shut down too far to accept any
I/O that the shutdown might generate. Any generated I/O actually
triggers a panic.
Fix this by calling scsi_remove_host() as early as possible and not
calling scsi_host_put() until just before we kfree the ahc_softc.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/aic7xxx/aic7xxx_osm.c')
-rw-r--r-- | drivers/scsi/aic7xxx/aic7xxx_osm.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 876d1de8480d..6ee1435d37fa 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c | |||
@@ -1209,11 +1209,6 @@ ahc_platform_free(struct ahc_softc *ahc) | |||
1209 | int i, j; | 1209 | int i, j; |
1210 | 1210 | ||
1211 | if (ahc->platform_data != NULL) { | 1211 | if (ahc->platform_data != NULL) { |
1212 | if (ahc->platform_data->host != NULL) { | ||
1213 | scsi_remove_host(ahc->platform_data->host); | ||
1214 | scsi_host_put(ahc->platform_data->host); | ||
1215 | } | ||
1216 | |||
1217 | /* destroy all of the device and target objects */ | 1212 | /* destroy all of the device and target objects */ |
1218 | for (i = 0; i < AHC_NUM_TARGETS; i++) { | 1213 | for (i = 0; i < AHC_NUM_TARGETS; i++) { |
1219 | starget = ahc->platform_data->starget[i]; | 1214 | starget = ahc->platform_data->starget[i]; |
@@ -1242,6 +1237,9 @@ ahc_platform_free(struct ahc_softc *ahc) | |||
1242 | 0x1000); | 1237 | 0x1000); |
1243 | } | 1238 | } |
1244 | 1239 | ||
1240 | if (ahc->platform_data->host) | ||
1241 | scsi_host_put(ahc->platform_data->host); | ||
1242 | |||
1245 | free(ahc->platform_data, M_DEVBUF); | 1243 | free(ahc->platform_data, M_DEVBUF); |
1246 | } | 1244 | } |
1247 | } | 1245 | } |